Ahmed Ashour
3564d4b4ba
Remove redundant interface already implemented by super class. (#10258)
6 anos atrás
Ahmed Ashour
10bd7544fd
Improve naming of fields and variables (#10242)
* Variable names to conform to naming convention.
* Use static constants where it makes sense
6 anos atrás
Ahmed Ashour
7c8f440781
Remove trailing spaces (#10224)
6 anos atrás
Ahmed Ashour
69ac68e064
Fix typos (#10213)
* Fix typos
* Fix
6 anos atrás
Ahmed Ashour
a9c83ba07e
Use .toLowerCase and .toUpperCase(Locale.ROOT) (#10182)
* Use .toLowerCase and .toUpperCase(Locale.ROOT)
* Spaces
* add spaces after if(
6 anos atrás
Ahmed Ashour
c265cd1d6e
Fix HTML tags inside code in javadoc (#10160)
* Fix HTML tags inside code in javadoc
* only modify <table> and <tr>
* Fix javadoc
6 anos atrás
Ahmed Ashour
0f4702c6d1
Add spaces after 'if' and 'for' in JavaScript (#10199)
* Add spaces after 'if' and 'for' in JavaScript
* Revert to old format
* Remove whitespaces
6 anos atrás
Ahmed Ashour
f42e0cc6f2
Fix some checkstyle warnings (#10179)
6 anos atrás
Ahmed Ashour
c147b5d85b
Use Collection.isEmpty() (#10172)
6 anos atrás
Ahmed Ashour
fa62729e24
Fix typos (#10158)
6 anos atrás
Ahmed Ashour
ab18b6c58e
Remove unneeded .toString() (#10141)
6 anos atrás
Ahmed Ashour
9494818412
Use StringBuilder instead of StringBuffer (#10154)
6 anos atrás
Ahmed Ashour
83f5e593f6
Fix typos (#10124)
6 anos atrás
Ahmed Ashour
7e4b4ff5a9
Use enhanced for loop for arrays. (#10121)
6 anos atrás
Ahmed Ashour
43f4a17f0d
Simplify conditional logic. (#10122)
And remove unused imports.
6 anos atrás
Ahmed Ashour
763a5cbe8c
First sentence of javadoc should end with a period (#10114)
Also includes minor other javadoc and formatting fixes.
6 anos atrás
Ahmed Ashour
adcf2e2e80
Use enhanced for loop instead of Iterator. (#10100)
6 anos atrás
Ahmed Ashour
46950473fd
UIDL to implement Iterable (#10101)
6 anos atrás
Ahmed Ashour
7065740d6d
Use interface instead of implementation (#10073)
6 anos atrás
Ahmed Ashour
7fd440d244
Use single character for StringBuilder.append (#10102)
6 anos atrás
Ahmed Ashour
9e6490d32a
Fix typos (#10095)
6 anos atrás
Adam Wagner
697f770287
Implement error level on client side (#9817)
Add additional class names and style to components and error indicators to distinguish different error levels.
Vaadin 8 implementation of #9816 . Cherry picked changes and added compatibility package component changes and tests.
Resolves #3139
6 anos atrás
Ahmed Ashour
3c0c3e0a99
Fix typos (#10071)
And use varargs in a test.
6 anos atrás
Ahmed Ashour
40d15b32e3
Construct array inline (#10068)
And some trivial test enhancements
6 anos atrás
Ahmed Ashour
d3c752e0f2
Add empty line at end of file
6 anos atrás
Ahmed Ashour
73119c7193
Fix javadoc references (#10067)
And remove unused imports.
6 anos atrás
Ahmed Ashour
60ff3d6c34
Format curly brackets correctly for checkstyle (#10066)
6 anos atrás
Ahmed Ashour
23718371f8
Remove unused methods. (#10058)
6 anos atrás
Henri Sara
a18842e2ae
Replace tabs with spaces in Java files
6 anos atrás
Ahmed Ashour
1b8d507e5b
Replace iff with if in javadoc (#10056)
6 anos atrás
Ahmed Ashour
132d9fa60e
Fix unused parameters in javadoc (#10055)
6 anos atrás
Ahmed Ashour
11ddb11cbc
Update modifier order to follow Java Specification suggestions (#10050)
Also includes some other minor cleanup.
6 anos atrás
Ahmed Ashour
e118f4d860
Access static members in a static way (#10054)
6 anos atrás
Ahmed Ashour
867006d2f8
Use String.isEmpty() (#10045)
6 anos atrás
Ahmed Ashour
62d49f3c3a
Implement hashCode() when implementing equals()
6 anos atrás
Ahmed Ashour
4a8195b59e
Replace iterators with enhanced for loops (#10018)
This change also includes some other minor cleanup.
6 anos atrás
Ahmed Ashour
8bb5f30251
Fix javadoc typos (#9998)
6 anos atrás
Ahmed Ashour
229792f642
Javadoc fixes
6 anos atrás
Ahmed Ashour
03349e8c66
Simplify boolean expressions
6 anos atrás
Aleksi Hietanen
774e2164ef
Fix missing since tag in compatibility package Grid
6 anos atrás
Ansku
3b2bea5236
Resize should work within Grid details row (#9808)
Fixes #7341
6 anos atrás
Knoobie
7b1e48f469
Make clicking checkbox label call focus listeners (#9271)
Fixes the remaining issue from #3944 for Firefox so that a click on the checkbox label calls the focus listener.
Fixes #9290
7 anos atrás
Artur
7bf4f7ade8
Detect Chrome on iOS as Chrome + Webkit (#9138)
7 anos atrás
Teemu Suo-Anttila
8b95318c6c
Fix issues in Grid with undefined height (#9104)
7 anos atrás
Aleksi Hietanen
7d1b06cbc4
Fix client-side memory leak caused by Grid events (#9103)
Refactors AbstractGridKeyEvent, AbstractGridMouseEvent and their
descendants to follow the pattern used in other GWT DomEvents.
Fixes #7633
7 anos atrás
Henri Sara
300f691b19
Add missing methods to compatibility AbstractRendererConnector
Fixes #9096
7 anos atrás
Artur
833e6e3bd9
Always calculate Escalator max row count the same way (#8740)
* Rename getMaxEscalatorRowCapacity to describe what it does
* Always calculate Escalator max row count the same way
This changes Escalator to not take a horizontal scrollbar
into account when trying to determine "maximum visible rows". This will
add another row, compared to previous versions, when there is a horizontal
scrollbar. In reality, it would likely make sense to always add 10 more rows
to have some buffer above and below the visible area.
Fixes #8661
7 anos atrás
Ilia Motornyi
264ee76965
Fix Upload and push in TabSheet (#8782)
Also fixes JSNI calls in compatibility Upload component.
Fixes #8728 for the compatibility package
7 anos atrás
Ilia Motornyi
82ea08974b
Fix JSNI calls in compatibility Escalator (#8783)
7 anos atrás
Ahmed Ashour
76713bbb4c
Remove extra empty javadocs before package declaration (#8776)
7 anos atrás