Ahmed Ashour
3763f3f94c
Use lambda expressions. (#10268)
6 anos atrás
Ahmed Ashour
04905e1e2e
Use local variable for getWidget(). (#10253)
In some places, getWidget() is called many times, and I believe this can
have a litte performance improvement, since in some cases
super.getWidget() is called more than once.
6 anos atrás
Ahmed Ashour
d44a5e217d
Fix end of line comments, which were made by automatic formatter (#10234)
6 anos atrás
Ahmed Ashour
3564d4b4ba
Remove redundant interface already implemented by super class. (#10258)
6 anos atrás
Adam Wagner
ffe1e0c022
Fix combo box suggestion popup height (#10256)
Fixes #10214
6 anos atrás
Knoobie
e65efdfb50
add Grid.Column#get/setAssistiveCaption (#10219)
* add Grid#Column#get/setAssistiveCaption
* fix test and update doc
* move testGridAssistiveCaption to GridTest
* delete test file
* delete test file
* Delete GridAssistiveCaptionTest.java
* Create GridAssistiveCaptionTest
* Create GridAssistiveCaption
* Rename GridAssistiveCaption to GridAssistiveCaption.java
* Rename GridAssistiveCaptionTest to GridAssistiveCaptionTest.java
* Reformat using eclipse
6 anos atrás
Ahmed Ashour
fb6e81221b
Use lambda with Handlers (#10229)
Also improve naming by replacing one-letter variable names.
6 anos atrás
Ahmed Ashour
01c93a6aef
Use lambda with Listeners (#10222)
Also use "event" as the name for events
6 anos atrás
Ahmed Ashour
10bd7544fd
Improve naming of fields and variables (#10242)
* Variable names to conform to naming convention.
* Use static constants where it makes sense
6 anos atrás
Ahmed Ashour
7c8f440781
Remove trailing spaces (#10224)
6 anos atrás
Knoobie
d0dde67c18
adds simple fix for missing label text in grid select checkboxes (#10223)
* adds simple fix for missing label text in grid select checkboxes
* updated comment and wording
6 anos atrás
Ilia Motornyi
a2497cf015
Unlock panel caption div hacking (#10120)
* Unlock panel caption div hacking
Fixes #10119
* Javadoc formatting fix
6 anos atrás
Ahmed Ashour
3929d0ac6f
AbstractDateField.formatDate() to be abstract (#10186)
* AbstractDateField.formatDate to be abstract
Remove invalidDateString paramter, as it can be deduced
* Fix test
* Remove AbstractDateField.getResolutionVariable
VAbstractTextualDate: rename updateDateVariables() to updateBufferedResolutions()
* Revert to use fixed value of MONDAY.
* release notes
* updateAndSendBufferedValues()
* Missed call to updateAndSendBufferedValues();
* release note
6 anos atrás
Ahmed Ashour
69ac68e064
Fix typos (#10213)
* Fix typos
* Fix
6 anos atrás
Adam Wagner
df2157ab9f
Check class name type on Grid cell mouse over (#10194)
* Check whether className is of type string
* Move string type checker method to widget util
* Fix formatting of WidgetUtil
* Break svg into lines
6 anos atrás
Knoobie
cb85b62828
Improve role usage in grid (#10206)
* add role="row" and role="gridcell"
* optimize code and add additional rows for the header
* add simple test
* improve code and add rowgroup
* add debug log
* add more log to test
* remove debug test info and add role before appending to tr
* wording - change contains to contain
* create enum for magic strings, change comments and method signature
* rename enum to be singular and rename param roleName to role
* update javadoc, rename and make enum public
6 anos atrás
Ahmed Ashour
a9c83ba07e
Use .toLowerCase and .toUpperCase(Locale.ROOT) (#10182)
* Use .toLowerCase and .toUpperCase(Locale.ROOT)
* Spaces
* add spaces after if(
6 anos atrás
Ahmed Ashour
c265cd1d6e
Fix HTML tags inside code in javadoc (#10160)
* Fix HTML tags inside code in javadoc
* only modify <table> and <tr>
* Fix javadoc
6 anos atrás
Ahmed Ashour
03570cb874
Scheduler.ScheduledCommand and RepeatingCommand to be lambda (#10203)
* Scheduler.ScheduledCommand and RepeatingCommand to be lambda
* Restore <table> in javadoc
* Fix docs
6 anos atrás
Ahmed Ashour
0f4702c6d1
Add spaces after 'if' and 'for' in JavaScript (#10199)
* Add spaces after 'if' and 'for' in JavaScript
* Revert to old format
* Remove whitespaces
6 anos atrás
Ahmed Ashour
780e9cee6b
Simplify lambda expressions (#10198)
* Simplify lambda expressions
And remove unneeded 'return' keyword.
* Format
6 anos atrás
Ahmed Ashour
4148d910a5
Fix AbstractDateField to correctly show week day names (#10188)
Fixes #9200
6 anos atrás
Ahmed Ashour
f42e0cc6f2
Fix some checkstyle warnings (#10179)
6 anos atrás
Ahmed Ashour
dd5597d901
Convert AbstractDateField not to be a LegacyComponent (#10148)
6 anos atrás
Ahmed Ashour
c147b5d85b
Use Collection.isEmpty() (#10172)
6 anos atrás
Ahmed Ashour
13d406a708
Remove redundant null checks before an instanceof (#10173)
6 anos atrás
Knoobie
0843f53881
Add aria-rowcount to grid (#10167)
This is based on discussion from vaadin/vaadin-grid#1023 .
6 anos atrás
Piotr Wilkin
69c6675572
Fix for Grid client-side exception. (#10166)
Do not try to update the select all checkbox if it is not visible.
Fixes #10164
6 anos atrás
Ahmed Ashour
fa62729e24
Fix typos (#10158)
6 anos atrás
Ahmed Ashour
ab18b6c58e
Remove unneeded .toString() (#10141)
6 anos atrás
Piotr Wilkin
802bb98b85
Edit grid row by index - server side (#10040)
Opening grid editor from server side.
Fixes #8477 .
Addressing #8820 will be the user's responsibility as fetching index of item might be slow.
6 anos atrás
Ahmed Ashour
9494818412
Use StringBuilder instead of StringBuffer (#10154)
6 anos atrás
Ahmed Ashour
ce3f5a04a5
Add empty line at the end of files (#10142)
6 anos atrás
Ahmed Ashour
83f5e593f6
Fix typos (#10124)
6 anos atrás
Ahmed Ashour
f265739578
Registration to remove state.registeredEventListeners (fixes #9634) (#10130)
This changes SharedState.registeredEventListeners to be a Map that keeps track of how many listeners of each type have been added, and handles unregistering of such listeners correctly.
6 anos atrás
Knoobie
80336d30ed
Add role="grid" and aria-multiselectable to grid (#10009)
Also adds aria-selected for grid rows.
6 anos atrás
Ahmed Ashour
ccad305464
Use static import of Assert in tests (#10126)
Also removes dependency on junit.framework.TestCase .
6 anos atrás
Ahmed Ashour
7e4b4ff5a9
Use enhanced for loop for arrays. (#10121)
6 anos atrás
Ahmed Ashour
43f4a17f0d
Simplify conditional logic. (#10122)
And remove unused imports.
6 anos atrás
Ahmed Ashour
763a5cbe8c
First sentence of javadoc should end with a period (#10114)
Also includes minor other javadoc and formatting fixes.
6 anos atrás
Ahmed Ashour
adcf2e2e80
Use enhanced for loop instead of Iterator. (#10100)
6 anos atrás
Ahmed Ashour
46950473fd
UIDL to implement Iterable (#10101)
6 anos atrás
Henri Sara
198ec82c51
Add since tags and update release notes (#10109)
6 anos atrás
Ahmed Ashour
c520767bf1
Handle 'z' (timezone) in AbstractDateField.setDateFormat() (#8844)
6 anos atrás
Henri Sara
131601de36
Update empty since tags for 8.2 (#10107)
6 anos atrás
Ahmed Ashour
7065740d6d
Use interface instead of implementation (#10073)
6 anos atrás
Ahmed Ashour
7fd440d244
Use single character for StringBuilder.append (#10102)
6 anos atrás
Ahmed Ashour
9e6490d32a
Fix typos (#10095)
6 anos atrás
Ahmed Ashour
9f9efe0058
Support addCloseListener for Notification (#10027)
Converts Notification to an Extension and adds support for listening to the closing of notifications.
Fixes #888
6 anos atrás
Ahmed Ashour
22566d5d9d
Convert Embedded not to be a LegacyComponent (#10088)
6 anos atrás