- Replace the GridDisabledTest screenshot usage
- Replace the screenshot tests in BasicCrudGridEditorRowTest
- Replace the screenshot tests in ComboboxVaadinIcons
- Replace the screenshot tests in ValoThemeUITest::accordions
- Added screenshotcomparetolerance to some screenshot test to make tests stable

issue in #11343 and #11385 is not reproducible on top this patch
Three different bugs are involved in this fix:
we bring the old fix(#11094) back and fixed the other related issues:
1) allow adding the same new item after dataProvider got reset, This is cause by the client side parameter `LastNewItemString`, it saves the value added before resetting. 
2) clear the pending newItem eagerly, so that the same value will not be added again.

Fixes 11528

Checking that no prior Combobox behavior is broken

* Cleaning-up the code

Adding UI test

* Adding TestBench test

* Request data update before client response

* fix the accidental commit

* add tests

fixes #11320

* Revert "Update ComboBox internal state on new item added (#11094)"

This reverts commit 56ce91c616.

* Add tests to verify the issue

Ignoring filtering options when right arrow, left arrow, home or end key is pressed.

Fixes #11016

* Fix using ConnectorResource icons before attaching ComboBox

* Update Chrome and PhantomJS screenshots

Fixes vaadin/testbench#1009

Fixes #10660

Fixes #10624

Fixes #10284

Fixes #10214

Also improve naming by replacing one-letter variable names.

Also use "event" as the name for events

* Use .toLowerCase and .toUpperCase(Locale.ROOT)

* Spaces

* add spaces after if(

And some trivial test enhancements

Keep the ComboBox popup at the same position relative to the ComboBox
when the view is scrolled.

Fixes #5043

Fixes #9637

Fixes #9079

Fixes #8778

* Reduce ComboBox initial requests

Use initial fetched data on client side,
do not request data from server side for each time popup is opened.
Fixed initial filter being null for ComboBox on DataProvider,
causing unnecessary size & fetch for not-changed filter.
Fixed ComboBox sending default filter unnecessarily to server.
Fixed wrong page indexing in VComboBox -> ComboBoxConnector.

Fixes #8496
Fixes vaadin/framework8-issues#488

* Fix last item missing

When pageLength was 0 and nullSelectionAllowed,
the last item was not shown. Tried to sensify the API
for total suggestions versus total suggestions + null selection item.

* Fix ComboBox selected item updates

Handles changing of ItemCaptionGenerator or ItemIconGenerator,
need to update the selected item caption and icon separately.
Previously it worked because all data was sent all the time to client.
Doesn't fix the issue, when selected item is updated with refreshItem(),
and it is not on the active range that will be sent to client.
For that, ComboBox would need a separate notification about item update.

* Updated screenshots

* Include FontAwesome by default for easier migration
* Fix JSComponentLoadingIndicatorTest

Fixes #7979
Addresses part of #8219

Only one UI smoke test for the SQL container (along with a Table).

Fixes vaadin/framework8-issues#582

Renamed corresponding test packages too.

Fixes vaadin/framework8-issues#110

Fixes vaadin/framework8-issues#163


Change-Id: Ib68ad5421934c8375a91d7948d860381a5adb9bb

Change-Id: I60c5d9f183d1955fbbd3341e3ac9f93aae755f80

Listing has been moved from AbstractListing to each individual Component.

ComboBox is now typed to String filter.

Fixes issues with declarative read of items.

Change-Id: I6918f9f8c426dcbd81546150c2cf9ed49a02bf50

Change-Id: Ic65b8decb3ac8d4dde9bca6cfb40a2a70f461e91

Change-Id: I6babcadc72f3f37feff98088eee23b153a080f11

Extracts grid single selection into separate class, which
is an extension like in V7. Using an extension makes it
possible to easily add multiselect and no-select modes back,
and support custom selection models.

Adds Grid:asSingleSelect() SingleSelect so that grid can be
used as a Select in a binder.

Removes all remaining references to SelectionModels in Listings.
Renames SingleSelectionChangeEvent to SingleSelectionEvent, because
then it is unified with selection listener and MultiSelectionEvent.

Fixes vaadin/framework8-issues#424
Fixes vaadin/framework8-issues#425

Change-Id: Ie22bef29cfd4336c3f65d4e63531c578b8dd76a3

All components are now in immediate mode by default.
V7 compatibility components will use AbstractLegacyComponent that has immediate.
V7 ColorPickerPopup will not have setImmediate, since it extends V8 Window,
which is not in V7 compatibility packages.
Removed OutOfSync and ResynchronizeAfterAsyncRemoval Tests,
since those tested UI in not immediate mode, which is invalid now.
Removed WindowResizeListener, LazyWindowResize, test UIs,
since both used immediate and there were no test run for either.

Change-Id: Ie1c8cfa4c48461db944ff9b13efe8473c5a3298f

LegacyApplication explicitly uses "reindeer" as default theme.
Extended AbstractTestUI to AbstractReindeerTestUI, that all old tests now inherit.
All new tests should be based on AbstractTestUI.
Also added AbstractReindeerTestUIWithLog for those that needed it.
Removed all found @Theme("valo") and used proper parent test class.

Change-Id: I0bb45850f3f1d39c6f78dac35dfa08acbad427ad

ItemDataSource generates "Item n" strings on the fly.

Change-Id: Icc87776b3ad3eaf0a93de6ebcf5bd9f1fcd21757

This patch updates server side add*Listener methods to return
a registration object and deprecates their corresponding
remove*Listener methods.

Additionally this patch removes add/removeListener methods which were
deprecated in 7.0.

Change-Id: I26ac5f11882512288fbbf601c7cb2aaff653ec76

Change-Id: I884a52c75b3be5573cf6634f211d72d09de69d80