Do not wait for icons to load before interacting with a combo box (#9717)
Icon load detection code does not handle error events so broken images
will cause tests to fail forever. In other cases also, it seems very
rare to need icons to be loaded before interacting with a combo box. If
there really are use cases for this, it would be better to have a method
to query if all icons are loaded so that special tests can use this method.
Fixes https://github.com/vaadin/testbench/issues/916
Currently the reset method resets the lastFilter as well and then the logic thinks items don’t need to be refreshed when popup is reopened.
Fixes #9027
Fixes #7790
* Reduce ComboBox initial requests
Use initial fetched data on client side,
do not request data from server side for each time popup is opened.
Fixed initial filter being null for ComboBox on DataProvider,
causing unnecessary size & fetch for not-changed filter.
Fixed ComboBox sending default filter unnecessarily to server.
Fixed wrong page indexing in VComboBox -> ComboBoxConnector.
Fixes #8496
Fixes vaadin/framework8-issues#488
* Fix last item missing
When pageLength was 0 and nullSelectionAllowed,
the last item was not shown. Tried to sensify the API
for total suggestions versus total suggestions + null selection item.
* Fix ComboBox selected item updates
Handles changing of ItemCaptionGenerator or ItemIconGenerator,
need to update the selected item caption and icon separately.
Previously it worked because all data was sent all the time to client.
Doesn't fix the issue, when selected item is updated with refreshItem(),
and it is not on the active range that will be sent to client.
For that, ComboBox would need a separate notification about item update.
* Updated screenshots
Add a maven plugin for formatting according to Eclipse settings
Running formatter:format will format all files in a submodule using an
embedded Eclipse compiler (based on Neon SR1)
according to the regular formatting settings file.
Update ComboBox for new DataSource and communication mechanism
This simplifies the client side state machine.
This change does not modify the CSS class name v-filterselect.
Change-Id: I2f4a6e5252045cb7698d582be90693e00961b342
Move and rename server classes which go into the compatibility package
* Use com.vaadin.v7
* Use the same class name as in Vaadin 7
* Use a "vaadin7-" declarative prefix for Vaadin 7 components
Change-Id: I19a27f3835b18980b91a4f8f9464b2adde1a5fd5
- Move waitingForFilteringResponse etc. to the data received
handler.
- Change some setters to parameterless methods that trigger a
state transition.
Change-Id: Iaf2547df1e6e61a1cb25b74172ea0fb095068375
Use a separate data received handler in VFilterSelect (#19929)
Move parts of the request handling to a separate handler
class that keeps track of the current communication state etc.
This is an intermediate change. Later changes should move
waitingForFilteringResponse etc. to the handler.
Change-Id: Ic248aa463ae0b194f95e5e4ce92e9d26627ddfeb
Move the handling of selection when a navigation operation
pends on server reply to the connector, with a callback
that actually performs the selection.
Change-Id: I941defbf2fe85d0f4d6ed58b7e65799c35a11aa1
This is an intermediate step towards refactoring the
communication related client side internal state management.
Change-Id: I252988cae5e19883ea0acc283bdda69473dc4f85
Use shared state for the page length and update related tests.
This change also removes an unused widget field.
Change-Id: I22055ea058029f898af952252a0c3dadcd9476d4
Send focus and blur events using RPC instead of in UIDL.
This change does not use ConnectorFocusAndBlurHandler to preserve
old timings.
Change-Id: I02a86dcc3959388ca835798a33cb600898b19ab9
This change extracts the client to server communication
methods of VFilterSelect and moves them to the connector.
Change-Id: If9b10455d1d32e11bfd6077dcaccbc4841b300f0
Without the fix, when selecting a value from page n+1 and re-opening the
ComboBox popup, the content of the text box may disappear.
Change-Id: I5fb57c0e5a068645f4b11fb1c392e682dd04b06a
Fixing ComboBox page flip on trackpad scroll (#19704)
Trackpad scroll gesture produces a large amount of wheel events causing
the same amount of flips on ComboBox. This fix tries to control page flips
in a way that it would feel more natural to use it.
Change-Id: I3ed206a5abe8c3ba8c06a5998f788468157663f1
Ahmed Ashour
Henri Sara
Artur
Teemu Suo-Anttila
Matti Tahvonen
Teemu Suo-Anttila
Pekka Hyvönen
Leif Åstrand
Denis Anisimov
Henri Sara
adam