vaadin-framework

18857 Commits

114 Branches

Tree: 95a01fe72e

Commit Graph

Author	SHA1	Message	Date
Anna Koskinen	95a01fe72e	Improvements to ScrollDestination sanity checks (#11772) (#11776) - The new top row logical index should always be within the logical range and high enough up to avoid leaving a gap if possible. - Added regression testing for using the different scroll destination types for scrolling to the top and to the bottom by index. Fixes #11732	4 years ago
Anna Koskinen	5cce360277	Fix scrollTo for destination START and END and add regression testing. (#11711) - Initial implementation erroneously assumed that ScrollDestination.START would only be used for scrolling up and ScrollDestination.END for scrolling down. That's obviously not what they are for, otherwise everyone would be using ScrollDestination.ANY. - Moved actual scrolling to within the helper method that originally only calculated the new scroll position. Parent method became too long otherwise. Fixes #11706	4 years ago

Author

SHA1

Message

Date

Anna Koskinen

95a01fe72e

Improvements to ScrollDestination sanity checks (#11772) (#11776)

- The new top row logical index should always be within the logical
range and high enough up to avoid leaving a gap if possible.
- Added regression testing for using the different scroll destination
types for scrolling to the top and to the bottom by index.

Fixes #11732

4 years ago

Anna Koskinen

5cce360277

Fix scrollTo for destination START and END and add regression testing. (#11711)

- Initial implementation erroneously assumed that
ScrollDestination.START would only be used for scrolling up and
ScrollDestination.END for scrolling down. That's obviously not what they
are for, otherwise everyone would be using ScrollDestination.ANY.
- Moved actual scrolling to within the helper method that originally
only calculated the new scroll position. Parent method became too long
otherwise.

Fixes #11706

4 years ago

2 Commits (95a01fe72ea115bd6816f45bcb97423544df4ea3)