Prevent opening Table context menu on short tapping on iOS (#15297)
With this patch handling touchstart in Table body is prevented
if it is handled in Table row. This is the smallest patch that solves
the problem, refactoring remains an open problem.
Change-Id: Iea54210ee81a3fdf17e45c6c98026af9080abddf
Fix Table column header sorting on Chrome (#14796)
This fix is similar to the fix that has been made for other similar
cases (i.e. #13381).
Couldn't find a reliable way to reproduce the problem. Hopefully this
will fix the issue.
Was reproduced (before fix) on Google Chrome 40.0.2214.115 m on
TableSortingStopsWorkingOnChrome test one time (but then suddenly it
started to work again).
Was reproduced (before fix) on Project TableSorting once, as described
in the ticket. That project has been attached to the ticket.
Change-Id: Id901c9ce4a0a7c369572bf4374223851658aa703
After this patch navigation with PageDown, PageUp, Home, End works
properly. What was
changed in this patch (new state): the first visible row number is
updated before
sending selected rows to the server while handling these keys.
Change-Id: I3bdebc434f886ef55f90f3fed5fd607d5f65f87f
Table: column not expanding after setColumnExpandRatio (#15101)
Partial fix for setting/unsetting expand ratios of existing table.
Result of this patch:
1) when switching off column expand ratio, natural column width is
restored.
2) changes in method run() for the same (though incorrect) treatment of
expand ratio as in sizeInit()
Change-Id: I2119eb1041e205a54373ac40a9ce8fdd14d70ad8
Removed obsolete fix for webkit scrollbar issue. (#14203)
The fix was causing a flicker effect. Initial fix for #2138 was causing
a flicker effect, but the original issue is not reproducing currently
even when the previous fix is reverted.
Tested against tickets #3457, #3875, #7607, #6698 as well as filtering
out and removing rows.
Change-Id: I1aa6943eb93898d75c4e3c5b6d9326b95648bb1f
Fix multiselection pressing shift before starting (#13483)
selectionRangeStart wasn't set when starting a selection pressing shift.
SelectAllRowsTest was rewritten to enable extension to test this issue.
Change-Id: I1b578b28ba89fc8215ec853d92de09f44c2d58e6
Table handles both onMouseDown and onMouseUp events (#14347)
Now it has the same behaviour that the layout, and checks
that the element under the mouse matches to complete the
click action
Change-Id: I9c61dac24479913c1bb1094edaf8878749984342
Revert "Keyboard shift-selection now works as expected in VScrollTable. (#14094)"
This reverts commit 441371a. The commit caused rows selected in a multiselect
table to no longer be focused, which caused a number of regressions.
Change-Id: I42d960cec9dfe24852b40a623f32e2b467704491
Reverting multiple commits that caused 100+ regression tests to fail.
Commits reverted:
* 392e8a0 - Minor refactor to #14147 patch
* 8d470c9 - Context menu is not shown in Table body on mobi... (#13694)
* f7dc719 - Fix Table stuck scroll position after setting ... (#14147)
Change-Id: I3f5ed7fa15a9cfebce7a57662d229bf46118c5d6
Bottom component click scroll up the parent panel in a window (#12943)
Due to old fix for (#11994) the v-scrollable div of the window would
expand to 110% of its size then immediately back to the original size.
The first action, expanding the v-scrollable to 110% would decrease
the scrollTop value of our panel, while increasing its height. When
the revert back action would set the v-scrollable to its own size,
the panel's scrollTop would remain decreased, causing the scroll bar
to move up, hiding the ~10% at the bottom.
Fixed by calling Util.runWebkitOverflowAutoFix(); instead of changing
the height.
Change-Id: I79eafd1f9500c2e4c10dadbfc7100608c0732e04
Replace use of deprecated DOM.setStyleAttribute method (#13781)
This change is only a brain dead replacement of one specific method. In
some cases, there were some oddities in the surrounding code as well,
but these were left unresolved on purpose.
It should also be noted that DOM.setStyleAttribute just delegates to
element.getStyle().setProperty(), so any null references would have
caused problems already in the existing code.
Change-Id: I340122ac0767af9928076376f76e5bd2c5e19f9f
Made user-initiated column resizing take precedence over other updates (#13432)
VScrollTable ignores server-initiated changes to column size while the user is
dragging a table resizer element.
Change-Id: I2866246e7975a8ddddbfdc12a9d99fb2c813a870
Avoid eagerly layouting from VScrollTable.updateFromUIDL (#13188)
Closing a modal sub-window at the same time when TreeTable item is
removed, caused the detached Window being re-opened by
WindowConnector.postLayout() call.
This change adds a check in postLayout: continue operation only if the
window is attached to DOM. Or else, log a warning message about the
invalid postLayout call. Another change is in TreeTableConnector and
VScrollTable to disallow Util.notifyParentOfSizeChange(Widget, boolean)
with a boolean 'false' argument, when rendering is in progress. 'false'
causes an immediate LayoutManager.layoutNow() call, which is the main
reason for this issue.
Change-Id: I6f3e331b0feff9e7814ae1d749f6f7812dcd49ac
Mika Murtojarvi
Artur Signell
Steven Spungin
Teemu Suo-Anttila
Ilya Ermakov
Anna Miroshnik
Alexey Fansky
Mikael Grankvist
Sauli Tähkäpää
Matti Hosio
Sergey Budkin
Sara Seppola
Anna Koskinen
Taras Hupalo
Guillermo Alvarez
mtzukanov
Heikki Ohinmaa
Anthony Guerreiro
Dmitrii Rogozin
Markus Koivisto
Bogdan Udrescu
Juho Nurminen
Juuso Valli
Leif Åstrand
Denis Anisimov
Tomi Virtanen