Now calls directly to correct spacer container to update visibility
instead of doing extra work with recalculating everything.
Change-Id: I8625033012773a10983cd5d4f6ef3ce1be50ee26
Fix Grid and Escalator accessing of SubPartArguments
This patch removes an extra static method from Escalator and makes Grid
and Escalator call SubPartArguments create(String) method directly.
Change-Id: I6825bc89540c6183a8fddeded8133fb7ef8e23f1
Hiding/Unhiding Grid column when details row is open (#17691)
Fixes paintRemoveColumns and paintInsertColumns in Escalator.AbstractStaticRowContainer
to not include spacers in row count.
Fixes couple ColumnHidingTests for IE8.
Change-Id: I283ee9fcdf0f3a7d0019948a700225c27a25d701
- Fixed regression caused by #17423 in IE8
- Fixed fragile tests for focusing spacer content in Grid
- Changed TestCategory for EscalatorBasicClientFeaturesTest from 'escalator' to 'grid'.
Change-Id: I644f85a68fee643e468342093ad537dcd7bf8626
Revert "Reduce reflows when sizing columns (#17315)"
This reverts commit 103b329d32. It causes problems
with screenshot tests (GridColumnAutoWidthServerTest).
Change-Id: I1de4a44573b22e0bea8ffa2626724e2a182cb876
This patch increases the reported fps from 10 to 17 in Chrome and from 5
to 10 in Firefox. No automatic test since performance testing on our
shared testing infrastructure would be quite error-prone.
Change-Id: I0bb6af250743058a8f32bb2df89da97660e94b52
Fix invalid assumptions about empty Grid (#16734, #16684)
* Don't reset to default column sizes when adding row to emtpy escalator
* Don't wait for data after size is explicilty reset to 0
* Don't assume there were previous rows when adjusting focus on add
Change-Id: I59e8c0ef0c5633cf3678db63a660e3f1d1ca7d2a
Fixes subpixel allocation accuracy and speed (#16614, #16750)
This reverts workarounds used in subpixel quick fix commit
6133b2cffd. New logic uses Escalator's
more optimised multiple column width setting method.
Change-Id: I0863f9774e6efc26f01ebdb736b4847e4ef5354c
Escalator spacers are sized and placed like "fixed" (#16644)
The width of a spacer is now 100% of the viewport (width of escalator
minus possible scrollbars), and and are always horizontally frozen
with the viewport.
Change-Id: I6616747784cdb61551e144d941526dee815a7ef9
Fixes two bugs when inserting escalator rows with spacers open (#16644)
If the viewport is not yet filled with escalator rows, it didn't account for
spacers. Also, the scrollbar was updated incorrectly after adding
new rows.
Change-Id: Id9cab71c2c4b82331771d1243143eb9db0883a6c
Fixes Escalator row offsets with spacers open (#16644)
Caveat: Scrolling works, as long as it is done slowly, one-by-one.
When moving several rows in a batch, spacers are ignored and
rows end up underneath them.
Change-Id: I07d0135e4ac559f5553cd8dc85bca39061de69b7
Makes Escalator show scrollbars on some OSX settings (#16852)
If the OSX is configured to show scrollbars only while scrolling, Escalator
would previously have its scrollbars hidden underneath the DOM structure.
Change-Id: I6c1a05ba23f6555d9f7f4c484c066c5f7ae63ac3
Note that this patch is only a first step of many. This patch only
moves displayed rows when spacer dimensions change. Doing
anything else afterwards (even scrolling) will probably not (and
is not intended to) look good at this stage.
Change-Id: I4de6abd932f587682840396df7a56a7df710af69
Grid's SubPartAware logic was refactored, splitting it into both Grid
and Escalator. Also adds tests for grid details rows.
Change-Id: I4876a8a9a397eea35526e15f7e447c69b0d96983
Escalator supports adding spacer elements into DOM. (#16644)
This is the first step towards Grid's details rows: Escalator puts spacer elements
in the DOM, and is able to scroll around with them. The spacers are put in their
correct locations, but they will not affect the normal row elements in any way at
this time.
Change-Id: Id20090c4de117e07e332dcc81e9964360f778258
Teppo Kurki
patrik
Artur Signell
Teemu Suo-Anttila
elmot
Leif Åstrand
Pekka Hyvönen
Markus Koivisto
Henrik Paul
Jouni Koivuviita
Johannes Dahlström