Always show loading indicator for JavaScript RPC (#20235)
The change to not show loading indicator for JS RPC was done in
15a53d305e and looks like a refactoring
error.
Change-Id: If2a2818e0c4adc06479ecaf17764bf53fc89c095
Update DOM and update escalator row count in the correct order (#19442)
If you show a column when Grid has no horizontal scrollbar, and is scrolled
all the way down, and the number of visible rows is slightly more than N then
Escalator will adjust the row count when the scrollbar is shown so that N-1
rows are visible. During this operation, the DOM must be updated for the new
column.
Change-Id: I0b6c845f96a57be1d64ef4e735aa2f77efbe589a
Fix ComboBox paging when number of items equals page length (#20213)
When pageLength == number of items, no paging should be shown except
if null selection is allowed, then there should be a second page
with one item.
Change-Id: I01c00f0c9d75a1dbb80d11b07c37c8ad7334ea07
Discard for DateField when the data source contains null (#8069)
Earlier discard did not work (#8069) if the data source
contained null and the user entered an invalid value for date fields.
The discard logic has been changed such that the error indicators and
internal state of the date field is cleared also if the value entered by
the user is invalid and the data source is null.
attach() updates the value from the data source in the same way as
discard. The old logic in attach is retained.
Change-Id: I5d798a2fdc3d2f0e82a037ea3cb2f57b6432039e
Fix animation end listeners so they are always removed (#17903)
Fixes ComboBox suggestion popup so that it will not automatically
close when clicking the popup button, if the user happened to
double click on the button earlier.
Change-Id: I60936f82133ca89c2aef0dccff68092a11deff1c
Without this change, some browsers, like GoogleBot, don't properly render the page.
Instead of weird JS exception (and hit to server with 404) we should at least try
to render the app with all browser. As webikit/chromium based browsers are
nowadays most popular, falling back to "safari" permutation.
Change-Id: I4275110962432b2552d51715a86a8e815fe539ad
The main encoding problem was fixed in GWT 2.7.0.vaadin4.
Vaadin 8 is already fixed as it uses GWT 2.8
Change-Id: I78ea30c1ff81d44432cd82ecd23eda8eb86e6efb
As vaadin-client-compiler dependens on gwt-dev, the gwt-dev dependencies
are either bundled in gwt-dev or specified as transitive dependencies
for it, so there is no need to specify them again for
vaadin-client-compiler
Change-Id: Iec075a3b4a005ae7b2e331287d942357aafe277d
Fix Grid height calculation when HeightMode.ROW (#20104, #20074)
When Grid is inside of a Tab (Tabsheet or Accordion) and
height mode is set to HeightMode.ROW, layout happens
before row height is known. To fix that, an event is fired
and a handler starts a layout after everything is calculated.
Change-Id: Idc8de795956b387ec69adf1871cb7f557914d998
Fixing TabSheet scrolling within SplitPanel (#20052)
This patch fixes an issue with disappearing tabs in a TabSheet placed in a
SplitPanel.
Scrolling a tab into view needs to be done after layout has happened. Otherwise
the available width for TabSheet is unknown and causes unexpected behaviour.
Change-Id: Ibcea04ddadfafc5028efe44a6817517b16e21bde
Without the fix, when selecting a value from page n+1 and re-opening the
ComboBox popup, the content of the text box may disappear.
Change-Id: I5fb57c0e5a068645f4b11fb1c392e682dd04b06a
Fixed the compare filter to handle subclasses (#17169)
Earlier the comparision worked only if the item value was a subclass of
the value in comparator, but not in the other way around. Now the
compairision works if the one is a subclass of the other and both
implements Comparable.
Change-Id: I1bcbba94f1263915f838e948ed9d8b68a14aefd0
The test was based on the assumption that only the visible tabs are
in the DOM of the tab bar. This assumption was no longer true.
Furthermore, the test iterated over all tabs which led to performance
issues especially on IE8.
Change-Id: If8e904418bdb81cf2762475b317adb2b21dcc032
Fixing drag and drop file upload issue on windows (#19809)
Folder upload is not supported by most of the browsers and can cause
StreamVariable methods not fire on some configurations.
This fix tries to detect and prevent uploading of folders.
Change-Id: Ib6357ddaeda5549065ab8ef5f682f12ad5968bce
Support static inner classes when reading/writing declarative files (#20038)
Uses outer class name as package name for static inner classes. When reading,
there is no way to know that the class is an inner class so only when creating
a class fails, an inner class is tried as a backup.
Change-Id: I3ebf5b2da11384f9dc64072a3dc8ee132607237c
Since the fix for #13370 which causes tooltips to react to mouseOut,
TB tests for tooltips fail on Firefox because of an extraneous
mouseOut event from FirefoxDriver.
Tooltips do work in manual tests also on Firefox.
Change-Id: Ic6d73bb4487749618bbc5c7e3a8416107adb4856