onConnect was allways called with websocket = false. I think this is wrong, since if there was connection loss in websocket, now connection cannot be re-established in websocket mode.

Fixes: https://github.com/vaadin/framework/issues/7190

Cherry pick of https://github.com/vaadin/framework/pull/11884

By using a separate id we can avoid sending the sessions
CSRF token as a GET parameter when initializing a push connection.

Cherry-picked from #8700 to the 7.7 branch.

Using the same formatting in the 7.7 branch and the master branch
eases porting of fixes

Change-Id: I51b4693f2f120447702cf322ce4505608ad92987

Change-Id: I5c740f4e9cb28103bab199f9a552153d82277e7e

This reverts commit 79c8c696c0

Change-Id: I364bc4a77cff36f319cec86a793806a0406f78b4

Change-Id: Ifd93251fdc20b93ad276c551796557bb9026766a

Change-Id: I69df09f371aae61f9e1ef741814f6e3016510fe2

Change-Id: I1dc35f060b255baff4d28a815414836d4852218b

Removed invalid @since from MarginInfo.

Change-Id: I7ad0dee47e8686c5cbca05ca1363ae8741642be8

Change-Id: I99748db0f00a6b2189f557fa05a145906a841efc

* Initialize Atmosphere in a context listener as JSR-356 requires
* Do not run JSR-356 or websocket tests on servers without support
* Adds /run-jsr356/ for testing JSR-356 websockets with uitest.war
* Change push path to /PUSH (from /PUSH/) to be compatible with JSR 356
  endpoint mappings in Atmosphere (#14381)

Change-Id: Iec43f26df8c7b2bd347a713623a5298cc9e7b2cd

Change-Id: Ifaa0cddc1523f547d8d7f935e739889aa9ddd45a

Change-Id: I8b3cabc942600b3366f59697441d0613c9908a24

If we create an AtmospherePushConnection and a broadcaster like before we would
need to suspend the connection to ensure the AtmosphereResource is actually
added to the broadcaster

Change-Id: I7265ac0594b7a4da2c7a49fa34ebfbb27e1abdff

Change-Id: I26e53f6b07eaccc785bda547e454fa185ad952df

Revert "Fix handling of disconnection with push (#15330)"

This reverts commit 3c07368cbb.

Change-Id: I46631b1921fa1c5628952362a93a000df92c5a4a

* The resource should not be closed when the client disconnects
* Removed "automatic" disconnection which was needed when onresume was not handled
* Don't call disconnect twice for cancelled connections

Change-Id: Id5ad9924b56c8810f759d6f9dc1da6e83e53d75b

Change-Id: I61e0003a2301100a5f0bfc18581a279207c4e812

Change-Id: I4809fbbdb48f3e36c8e1da8552ff3fa734714105

All HTTP request based push request invoke onRequestStart/End in the servlet.
We need to trigger start/end separately in push handler only for websocket messages

Change-Id: I16064ea88b0c70812f247028ddb23560536db70d

Change-Id: Icdac51322a90c32c122a182bc692c4eff3d8285b

The setCurrent call on VaadinSession is not needed. the one extra call
can be saved because service.findVaadinSession will already set it.
Added a comment like it is done for UI (service.findUI will also set the
UI).

Change-Id: Ic24d922554d1316aae310813ef5d00a0bbfd418a

Correctly call PushConnection.disconnect instead of setting to null.
Also remove the obsolete PushHandler.disconnectCallback.

Change-Id: Ied055d489a269b016318947cd89cf0b46003c596

Change-Id: Ic77338304dc7e58e49f27dcdaf0bab2e00f5bba6

This used to happen when push was disconnected due to a UI or session
expiring. requestStart() and requestEnd() were called on disconnect
even though a disconnection is not a request.

Change-Id: I31d9cae65ec75b5046802a54bbe4564d6e44b29f

AbstractReflectorAtmosphereHandler handles cache requests correctly out of the box

Change-Id: I0ab96f53826cf181dc58b007fb6b4ec4eb4ad54d

Change-Id: I0956e31acfec605418eff0313fbcf82c3c7d6579

UIs now always have a PushConnection object if push is enabled,
and push reconnections do not create and set a new instance.
PushConnection.push can always be called; it internally handles
deferring the push until (re)connection if it is currently
disconnected. This is very desirable when using long polling,
as it reconnects after each push.

Change-Id: I478748cc940da86f34a5f55266f6b325682d4585

Change-Id: Ic2e9543266b449e29fb8e52715559d3fbf249d93

There are still issues in PushHandler where the wrong resource is used but these should not be as critical. They will be fixed in #12920

Change-Id: Ife8d3694bdb6ee29c5b4adbd8988cc0346c4fe3f

PushHandler now catches Exception and calls ErrorHandler more.

Change-Id: I7032c00f717b1dae34f4352abc035b1b398c7cfc

Change-Id: I0bab199632554655ef92a624f5654852b4b157d1

Client-side:

* Call onOpen() also after a successful reconnection
* Reliably call onClose() and try to reconnect after disconnection
* Don't try to reconnect if !isApplicationRunning() after push
* Queue messages while trying to reconnect (state CONNECT_PENDING)

Server-side:

* Implement AtmosphereResourceEventListener.onDisconnect()
* Push marked as pending until client reconnects (if ever)

Change-Id: I1783eb72eb7005b07cae786d8ec8371da3903108

* PushConnection is not Serializable anymore
* AtmospherePushConnection fields are not transient
* UI.setSession calls setPushConnection(null) instead of pushConnection.disconnect()
* pushConnection.disconnect() asserts isConnected()
* If UI has a push connection, it should now always have isConnected() == true

Change-Id: I3c2e877b8e723b7cc2993cacd620920aecdef5fb

Change-Id: I212067aa0bd04e3e73844ef57963b5622291986a

It appears that iOS6 will not make new request (at least for images) to a server to which there is already a connection open which possibly will be kept alive after the current request is done (Connection: Keep-alive asked by the client and not denied by the server)

Change-Id: If4e6233457fced3760a931b7953fa1713fee3452

Change-Id: Id0d82eabab63681b9d01c0312588fdfe1659860f

* First part of a fragmented message prefixed by total message length plus '|'
* Atmosphere websocket buffer size set to 65536
* Fragment size is 65535 characters (Jetty requires less than buffer size)

Change-Id: I8bf872bbb03b86386070fdc99c14ea805dd2ef3a

Change-Id: I10648c5b375efc09d3d20ffe0a620ddf01675bc1

Change-Id: I732bb26cfea9c5f59d85d6119d19a61e73381f5b

Change-Id: I83da8e1732296b6549a56de62b8c09660e39a8ec

* Added SessionExpiredHandler which any RequestHandler can implement to customize session expired handling
* The issue can be tested by creating a non-serializable UI (e.g. new Object() in a field) and restarting the server.

Change-Id: I3eb6bc56298e025bcde088af53ea656fb44e897b

* Can't open push connection during client-side init because CSRF token
is not available at that point. This allows simplifying the
initialization because the push state will not be checked until the
first response has been processed.
* Add helper for checking the CSRF token

Change-Id: I31da1ac669dc9a581cbd66f58c07f10ea4b8b676

Still missing is the ability to load vaadinPush.js if it has not yet
been loaded.

Change-Id: Ibe3596c38a7c4e3432b0396072866ee3072e6d30

This is one step towards support for toggling push on and off on demand
as that functionality requires accessing the UI e.g. when processing
cancel events.

Also ensures ThreadLocal instances are properly set up when handling
push events.

Change-Id: I8ed6bf3bbee5ede0696ed9017e1d9d84db5936b5

Change-Id: Idc0e5e00a8f3ddd3f56d87484089c290d52715c2

Change-Id: I00742d66052e318a023ed8ec2e3e5afbc7a3199f

Change-Id: I416dc73566e2404a6dce35045fc79f9038e8dd5e

Change-Id: I728c830d6740f77a200ea69925772924e58f45a4