vaadin-framework

Anastasia Smirnova c9dc0d64ec V7: Improve VMenuBar click handling logic (#11362) * Improve VMenuBar click handling logic Backport to V7: During `updateFromUIDL` inside MenuBarConnector we empty and re-instantiate the components of MenuBar. When we are modifying the Menubar from the BlurEventListener of another component, we ,by this, remove widgets, therefore clickEvent is not fired and the action of the MenuItem is not proceed as a result. (The BlurEvent is fired before the click event in the chain of events. ) To improve the situation, we catch onMouseDown event , which is fired before BlurEvent,by assigning mouseDown flag to true. Then if no click event has yet happened, we delay the execution of update inside `updateFromUIDL` by default 500 ms. Then if click event occurs, it proceeds normally. The time can be increased/decreased using setter. There is no delay, if we are clicking on the MenuBar as usual or no Blur listener is set. This change allows setting descriptions preserving the action from the MenuItem (cherry picked from commit `22cc85c76f`) * Improve VMenuBar click handling logic Add missing files from the first commit Backported to V7: (cherry picked from commit `22cc85c`)	5年前
..
main	V7: Improve VMenuBar click handling logic (#11362)	5年前
test/java/com/vaadin/shared	Make UPPER_CASE_PROPERTY_IDS more human friendly by default (#20380)	7年前

Anastasia Smirnova c9dc0d64ec V7: Improve VMenuBar click handling logic (#11362)

* Improve VMenuBar click handling logic

Backport to V7:
During `updateFromUIDL` inside MenuBarConnector we empty and re-instantiate the components of MenuBar. When we are modifying the Menubar from the BlurEventListener of another component, we ,by this, remove widgets, therefore clickEvent is not fired and the action of the MenuItem is not proceed as a result. (The BlurEvent is fired before the click event in the chain of events. )

To improve the situation, we catch onMouseDown event , which is fired before BlurEvent,by assigning mouseDown flag to true. Then if no click event has yet happened, we delay the execution of update inside `updateFromUIDL` by default 500 ms. Then if click event occurs, it proceeds normally. The time can be increased/decreased using setter.

There is no delay, if we are clicking on the MenuBar as usual or no Blur listener is set.

This change allows setting descriptions preserving the action from the MenuItem

(cherry picked from commit 22cc85c76f)

* Improve VMenuBar click handling logic

Add missing files from the first commit

Backported to V7:
(cherry picked from commit 22cc85c)

5年前

main V7: Improve VMenuBar click handling logic (#11362) 5年前

test/java/com/vaadin/shared Make UPPER_CASE_PROPERTY_IDS more human friendly by default (#20380) 7年前