vaadin-framework

Tree: 12fe44d807

Anastasia Smirnova 12fe44d807 Improve VMenuBar click handling logic (#11356) * Improve VMenuBar click handling logic During `updateFromUIDL` inside MenuBarConnector we empty and re-instantiate the components of MenuBar. When we are modifying the Menubar from the BlurEventListener of another component, we ,by this, remove widgets, therefore clickEvent is not fired and the action of the MenuItem is not proceed as a result. (The BlurEvent is fired before the click event in the chain of events. ) To improve the situation, we catch onMouseDown event , which is fired before BlurEvent,by assigning mouseDown flag to true. Then if no click event has yet happened, we delay the execution of update inside `updateFromUIDL` by default 500 ms. Then if click event occurs, it proceeds normally. The time can be increased/decreased using setter. There is no delay, if we are clicking on the MenuBar as usual or no Blur listener is set. This change allows setting descriptions * Remove accidentally committed comment * Don't update the state on the getDelayMs call	5 years ago
..
java/com/vaadin	Improve VMenuBar click handling logic (#11356)	5 years ago
resources	Add xsrf token header if cookie is present (#11034)	6 years ago

Anastasia Smirnova 12fe44d807 Improve VMenuBar click handling logic (#11356)

* Improve VMenuBar click handling logic

During `updateFromUIDL` inside MenuBarConnector we empty and re-instantiate the components of MenuBar. When we are modifying the Menubar from the BlurEventListener of another component, we ,by this, remove widgets, therefore clickEvent is not fired and the action of the MenuItem is not proceed as a result. (The BlurEvent is fired before the click event in the chain of events. )

To improve the situation, we catch onMouseDown event , which is fired before BlurEvent,by assigning mouseDown flag to true. Then if no click event has yet happened, we delay the execution of update inside `updateFromUIDL` by default 500 ms. Then if click event occurs, it proceeds normally. The time can be increased/decreased using setter.

There is no delay, if we are clicking on the MenuBar as usual or no Blur listener is set.

This change allows setting descriptions

* Remove accidentally committed comment

* Don't update the state on the getDelayMs call

5 years ago

java/com/vaadin

Improve VMenuBar click handling logic (#11356)

5 years ago

resources

Add xsrf token header if cookie is present (#11034)

6 years ago