You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

BinderValidationStatusTest.java 18KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501
  1. package com.vaadin.data;
  2. import static org.junit.Assert.assertEquals;
  3. import static org.junit.Assert.assertFalse;
  4. import static org.junit.Assert.assertNotNull;
  5. import static org.junit.Assert.assertNull;
  6. import static org.junit.Assert.assertSame;
  7. import static org.junit.Assert.assertTrue;
  8. import static org.junit.Assert.fail;
  9. import java.util.ArrayList;
  10. import java.util.List;
  11. import java.util.concurrent.atomic.AtomicReference;
  12. import org.junit.Assert;
  13. import org.junit.Before;
  14. import org.junit.Test;
  15. import com.vaadin.data.Binder.Binding;
  16. import com.vaadin.data.Binder.BindingBuilder;
  17. import com.vaadin.data.BindingValidationStatus.Status;
  18. import com.vaadin.tests.data.bean.Person;
  19. import com.vaadin.ui.Label;
  20. public class BinderValidationStatusTest
  21. extends BinderTestBase<Binder<Person>, Person> {
  22. protected final static BindingValidationStatusHandler NOOP = event -> {
  23. };
  24. @Before
  25. public void setUp() {
  26. binder = new Binder<>();
  27. item = new Person();
  28. item.setFirstName("Johannes");
  29. item.setAge(32);
  30. }
  31. //
  32. // Binding-level status handler
  33. //
  34. @Test
  35. public void bindingWithStatusHandler_handlerGetsEvents() {
  36. AtomicReference<BindingValidationStatus<?>> statusCapture = new AtomicReference<>();
  37. BindingBuilder<Person, String> binding = binder.forField(nameField)
  38. .withValidator(notEmpty).withValidationStatusHandler(evt -> {
  39. assertNull(statusCapture.get());
  40. statusCapture.set(evt);
  41. });
  42. binding.bind(Person::getFirstName, Person::setFirstName);
  43. nameField.setValue("");
  44. // First validation fails => should be event with ERROR status and
  45. // message
  46. binder.validate();
  47. assertNotNull(statusCapture.get());
  48. BindingValidationStatus<?> evt = statusCapture.get();
  49. assertEquals(Status.ERROR, evt.getStatus());
  50. assertEquals(EMPTY_ERROR_MESSAGE, evt.getMessage().get());
  51. assertEquals(nameField, evt.getField());
  52. statusCapture.set(null);
  53. nameField.setValue("foo");
  54. statusCapture.set(null);
  55. // Second validation succeeds => should be event with OK status and
  56. // no message
  57. binder.validate();
  58. evt = statusCapture.get();
  59. assertNotNull(evt);
  60. assertEquals(Status.OK, evt.getStatus());
  61. assertFalse(evt.getMessage().isPresent());
  62. assertEquals(nameField, evt.getField());
  63. }
  64. @Test
  65. public void bindingWithStatusHandler_defaultStatusHandlerIsReplaced() {
  66. Binding<Person, String> binding = binder.forField(nameField)
  67. .withValidator(notEmpty).withValidationStatusHandler(evt -> {
  68. }).bind(Person::getFirstName, Person::setFirstName);
  69. assertNull(nameField.getComponentError());
  70. nameField.setValue("");
  71. // First validation fails => should be event with ERROR status and
  72. // message
  73. binding.validate();
  74. // default behavior should update component error for the nameField
  75. assertNull(nameField.getComponentError());
  76. }
  77. @Test
  78. public void bindingWithStatusLabel_labelIsUpdatedAccordingStatus() {
  79. Label label = new Label();
  80. Binding<Person, String> binding = binder.forField(nameField)
  81. .withValidator(notEmpty).withStatusLabel(label)
  82. .bind(Person::getFirstName, Person::setFirstName);
  83. nameField.setValue("");
  84. // First validation fails => should be event with ERROR status and
  85. // message
  86. binding.validate();
  87. assertTrue(label.isVisible());
  88. assertEquals(EMPTY_ERROR_MESSAGE, label.getValue());
  89. nameField.setValue("foo");
  90. // Second validation succeeds => should be event with OK status and
  91. // no message
  92. binding.validate();
  93. assertFalse(label.isVisible());
  94. assertEquals("", label.getValue());
  95. }
  96. @Test
  97. public void bindingWithStatusLabel_defaultStatusHandlerIsReplaced() {
  98. Label label = new Label();
  99. Binding<Person, String> binding = binder.forField(nameField)
  100. .withValidator(notEmpty).withStatusLabel(label)
  101. .bind(Person::getFirstName, Person::setFirstName);
  102. assertNull(nameField.getComponentError());
  103. nameField.setValue("");
  104. // First validation fails => should be event with ERROR status and
  105. // message
  106. binding.validate();
  107. // default behavior should update component error for the nameField
  108. assertNull(nameField.getComponentError());
  109. }
  110. @Test(expected = IllegalStateException.class)
  111. public void bindingWithStatusHandler_addAfterBound() {
  112. BindingBuilder<Person, String> binding = binder.forField(nameField)
  113. .withValidator(notEmpty);
  114. binding.bind(Person::getFirstName, Person::setFirstName);
  115. binding.withValidationStatusHandler(evt -> fail());
  116. }
  117. @Test(expected = IllegalStateException.class)
  118. public void bindingWithStatusLabel_addAfterBound() {
  119. Label label = new Label();
  120. BindingBuilder<Person, String> binding = binder.forField(nameField)
  121. .withValidator(notEmpty);
  122. binding.bind(Person::getFirstName, Person::setFirstName);
  123. binding.withStatusLabel(label);
  124. }
  125. @Test(expected = IllegalStateException.class)
  126. public void bindingWithStatusLabel_setAfterHandler() {
  127. Label label = new Label();
  128. BindingBuilder<Person, String> binding = binder.forField(nameField);
  129. binding.withValidationStatusHandler(NOOP);
  130. binding.withStatusLabel(label);
  131. }
  132. @Test(expected = IllegalStateException.class)
  133. public void bindingWithStatusHandler_setAfterLabel() {
  134. Label label = new Label();
  135. BindingBuilder<Person, String> binding = binder.forField(nameField);
  136. binding.withStatusLabel(label);
  137. binding.withValidationStatusHandler(NOOP);
  138. }
  139. @Test(expected = IllegalStateException.class)
  140. public void bindingWithStatusHandler_setAfterOtherHandler() {
  141. BindingBuilder<Person, String> binding = binder.forField(nameField);
  142. binding.withValidationStatusHandler(NOOP);
  143. binding.withValidationStatusHandler(NOOP);
  144. }
  145. //
  146. // Binder-level status handler
  147. //
  148. @Test
  149. public void binderWithStatusHandler_fieldValidationNoBeanValidation_handlerGetsStatusUpdates() {
  150. AtomicReference<BinderValidationStatus<?>> statusCapture = new AtomicReference<>();
  151. binder.forField(nameField).withValidator(notEmpty)
  152. .withValidationStatusHandler(evt -> fail(
  153. "Using a custom status change handler so no change should end up here"))
  154. .bind(Person::getFirstName, Person::setFirstName);
  155. binder.forField(ageField).withConverter(stringToInteger)
  156. .withValidator(notNegative)
  157. .withValidationStatusHandler(evt -> fail(
  158. "Using a custom status change handler so no change should end up here"))
  159. .bind(Person::getAge, Person::setAge);
  160. binder.setValidationStatusHandler(r -> statusCapture.set(r));
  161. binder.setBean(item);
  162. assertNull(nameField.getComponentError());
  163. nameField.setValue("");
  164. ageField.setValue("5");
  165. // First binding validation fails => should be result with ERROR status
  166. // and message
  167. BinderValidationStatus<Person> status2 = binder.validate();
  168. BinderValidationStatus<?> status = statusCapture.get();
  169. assertSame(status2, status);
  170. assertNull(nameField.getComponentError());
  171. List<BindingValidationStatus<?>> bindingStatuses = status
  172. .getFieldValidationStatuses();
  173. assertNotNull(bindingStatuses);
  174. assertEquals(1, status.getFieldValidationErrors().size());
  175. assertEquals(2, bindingStatuses.size());
  176. BindingValidationStatus<?> r = bindingStatuses.get(0);
  177. assertTrue(r.isError());
  178. assertEquals(EMPTY_ERROR_MESSAGE, r.getMessage().get());
  179. assertEquals(nameField, r.getField());
  180. r = bindingStatuses.get(1);
  181. assertFalse(r.isError());
  182. assertFalse(r.getMessage().isPresent());
  183. assertEquals(ageField, r.getField());
  184. assertEquals(0, status.getBeanValidationResults().size());
  185. assertEquals(0, status.getBeanValidationErrors().size());
  186. nameField.setValue("foo");
  187. ageField.setValue("");
  188. statusCapture.set(null);
  189. // Second validation succeeds => should be result with OK status and
  190. // no message, and error result for age
  191. binder.validate();
  192. status = statusCapture.get();
  193. bindingStatuses = status.getFieldValidationStatuses();
  194. assertEquals(1, status.getFieldValidationErrors().size());
  195. assertEquals(2, bindingStatuses.size());
  196. r = bindingStatuses.get(0);
  197. assertFalse(r.isError());
  198. assertFalse(r.getMessage().isPresent());
  199. assertEquals(nameField, r.getField());
  200. r = bindingStatuses.get(1);
  201. assertTrue(r.isError());
  202. assertEquals("Value must be a number", r.getMessage().get());
  203. assertEquals(ageField, r.getField());
  204. assertEquals(0, status.getBeanValidationResults().size());
  205. assertEquals(0, status.getBeanValidationErrors().size());
  206. statusCapture.set(null);
  207. // binding validations pass, binder validation fails
  208. ageField.setValue("0");
  209. binder.validate();
  210. status = statusCapture.get();
  211. bindingStatuses = status.getFieldValidationStatuses();
  212. assertEquals(0, status.getFieldValidationErrors().size());
  213. assertEquals(2, bindingStatuses.size());
  214. assertEquals(0, status.getBeanValidationResults().size());
  215. assertEquals(0, status.getBeanValidationErrors().size());
  216. }
  217. @Test
  218. public void binderWithStatusHandler_fieldAndBeanLevelValidation_handlerGetsStatusUpdates() {
  219. AtomicReference<BinderValidationStatus<?>> statusCapture = new AtomicReference<>();
  220. binder.forField(nameField).withValidator(notEmpty)
  221. .withValidationStatusHandler(evt -> fail(
  222. "Using a custom status change handler so no change should end up here"))
  223. .bind(Person::getFirstName, Person::setFirstName);
  224. binder.forField(ageField).withConverter(stringToInteger)
  225. .withValidator(notNegative)
  226. .withValidationStatusHandler(evt -> fail(
  227. "Using a custom status change handler so no change should end up here"))
  228. .bind(Person::getAge, Person::setAge);
  229. binder.withValidator(
  230. bean -> !bean.getFirstName().isEmpty() && bean.getAge() > 0,
  231. "Need first name and age");
  232. binder.setValidationStatusHandler(r -> statusCapture.set(r));
  233. binder.setBean(item);
  234. assertNull(nameField.getComponentError());
  235. nameField.setValue("");
  236. ageField.setValue("5");
  237. // First binding validation fails => should be result with ERROR status
  238. // and message
  239. BinderValidationStatus<Person> status2 = binder.validate();
  240. BinderValidationStatus<?> status = statusCapture.get();
  241. assertSame(status2, status);
  242. assertNull(nameField.getComponentError());
  243. List<BindingValidationStatus<?>> bindingStatuses = status
  244. .getFieldValidationStatuses();
  245. assertNotNull(bindingStatuses);
  246. assertEquals(1, status.getFieldValidationErrors().size());
  247. assertEquals(2, bindingStatuses.size());
  248. BindingValidationStatus<?> r = bindingStatuses.get(0);
  249. assertTrue(r.isError());
  250. assertEquals(EMPTY_ERROR_MESSAGE, r.getMessage().get());
  251. assertEquals(nameField, r.getField());
  252. r = bindingStatuses.get(1);
  253. assertFalse(r.isError());
  254. assertFalse(r.getMessage().isPresent());
  255. assertEquals(ageField, r.getField());
  256. assertEquals(0, status.getBeanValidationResults().size());
  257. assertEquals(0, status.getBeanValidationErrors().size());
  258. nameField.setValue("foo");
  259. ageField.setValue("");
  260. statusCapture.set(null);
  261. // Second validation succeeds => should be result with OK status and
  262. // no message, and error result for age
  263. binder.validate();
  264. status = statusCapture.get();
  265. bindingStatuses = status.getFieldValidationStatuses();
  266. assertEquals(1, status.getFieldValidationErrors().size());
  267. assertEquals(2, bindingStatuses.size());
  268. r = bindingStatuses.get(0);
  269. assertFalse(r.isError());
  270. assertFalse(r.getMessage().isPresent());
  271. assertEquals(nameField, r.getField());
  272. r = bindingStatuses.get(1);
  273. assertTrue(r.isError());
  274. assertEquals("Value must be a number", r.getMessage().get());
  275. assertEquals(ageField, r.getField());
  276. assertEquals(0, status.getBeanValidationResults().size());
  277. assertEquals(0, status.getBeanValidationErrors().size());
  278. statusCapture.set(null);
  279. // binding validations pass, binder validation fails
  280. ageField.setValue("0");
  281. binder.validate();
  282. status = statusCapture.get();
  283. bindingStatuses = status.getFieldValidationStatuses();
  284. assertEquals(0, status.getFieldValidationErrors().size());
  285. assertEquals(2, bindingStatuses.size());
  286. assertEquals(1, status.getBeanValidationResults().size());
  287. assertEquals(1, status.getBeanValidationErrors().size());
  288. assertEquals("Need first name and age",
  289. status.getBeanValidationErrors().get(0).getErrorMessage());
  290. }
  291. @Test
  292. public void binderWithStatusHandler_defaultStatusHandlerIsReplaced() {
  293. Binding<Person, String> binding = binder.forField(nameField)
  294. .withValidator(notEmpty).withValidationStatusHandler(evt -> {
  295. }).bind(Person::getFirstName, Person::setFirstName);
  296. assertNull(nameField.getComponentError());
  297. nameField.setValue("");
  298. // First validation fails => should be event with ERROR status and
  299. // message
  300. binding.validate();
  301. // no component error since default handler is replaced
  302. assertNull(nameField.getComponentError());
  303. }
  304. @Test
  305. public void binderWithStatusLabel_defaultStatusHandlerIsReplaced() {
  306. Label label = new Label();
  307. Binding<Person, String> binding = binder.forField(nameField)
  308. .withValidator(notEmpty).withStatusLabel(label)
  309. .bind(Person::getFirstName, Person::setFirstName);
  310. assertNull(nameField.getComponentError());
  311. nameField.setValue("");
  312. // First validation fails => should be event with ERROR status and
  313. // message
  314. binding.validate();
  315. // default behavior should update component error for the nameField
  316. assertNull(nameField.getComponentError());
  317. }
  318. @Test(expected = IllegalStateException.class)
  319. public void binderWithStatusHandler_addAfterBound() {
  320. BindingBuilder<Person, String> binding = binder.forField(nameField)
  321. .withValidator(notEmpty);
  322. binding.bind(Person::getFirstName, Person::setFirstName);
  323. binding.withValidationStatusHandler(evt -> fail());
  324. }
  325. @Test(expected = IllegalStateException.class)
  326. public void binderWithStatusLabel_addAfterBound() {
  327. Label label = new Label();
  328. BindingBuilder<Person, String> binding = binder.forField(nameField)
  329. .withValidator(notEmpty);
  330. binding.bind(Person::getFirstName, Person::setFirstName);
  331. binding.withStatusLabel(label);
  332. }
  333. @Test(expected = IllegalStateException.class)
  334. public void binderWithStatusLabel_setAfterHandler() {
  335. Label label = new Label();
  336. BindingBuilder<Person, String> binding = binder.forField(nameField);
  337. binding.bind(Person::getFirstName, Person::setFirstName);
  338. binder.setValidationStatusHandler(event -> {
  339. });
  340. binder.setStatusLabel(label);
  341. }
  342. @Test(expected = IllegalStateException.class)
  343. public void binderWithStatusHandler_setAfterLabel() {
  344. Label label = new Label();
  345. BindingBuilder<Person, String> binding = binder.forField(nameField);
  346. binding.bind(Person::getFirstName, Person::setFirstName);
  347. binder.setStatusLabel(label);
  348. binder.setValidationStatusHandler(event -> {
  349. });
  350. }
  351. @Test(expected = NullPointerException.class)
  352. public void binderWithNullStatusHandler_throws() {
  353. binder.setValidationStatusHandler(null);
  354. }
  355. @Test
  356. public void binderWithStatusHandler_replaceHandler() {
  357. AtomicReference<BinderValidationStatus<?>> capture = new AtomicReference<>();
  358. BindingBuilder<Person, String> binding = binder.forField(nameField);
  359. binding.bind(Person::getFirstName, Person::setFirstName);
  360. binder.setValidationStatusHandler(results -> fail());
  361. binder.setValidationStatusHandler(results -> capture.set(results));
  362. nameField.setValue("foo");
  363. binder.validate();
  364. List<BindingValidationStatus<?>> results = capture.get()
  365. .getFieldValidationStatuses();
  366. assertNotNull(results);
  367. assertEquals(1, results.size());
  368. assertFalse(results.get(0).isError());
  369. }
  370. @Test
  371. public void binderValidationStatus_nullBindingStatuses() {
  372. try {
  373. new BinderValidationStatus<>(new Binder<Person>(), null,
  374. new ArrayList<>());
  375. Assert.fail("Binder should throw an NPE");
  376. } catch (NullPointerException npe) {
  377. assertNotNull(npe.getMessage());
  378. }
  379. }
  380. }