diff options
| author | Luc Didry <luc@didry.org> | 2024-09-12 15:32:44 +0200 |
|---|---|---|
| committer | backportbot[bot] <backportbot[bot]@users.noreply.github.com> | 2024-09-16 13:05:34 +0000 |
| commit | df397d969ead64d34384bb25c54d32e886aa51da (patch) | |
| tree | 353e3ad83592b505bc386a0322c88be9dea4dd31 | |
| parent | b96802956ff27ed7df5db3a3231b8069b9cdd034 (diff) | |
| download | nextcloud-server-df397d969ead64d34384bb25c54d32e886aa51da.tar.gz nextcloud-server-df397d969ead64d34384bb25c54d32e886aa51da.zip | |
fix(dav): catch `MaxInstancesExceededException` on calendar eventsbackport/47924/stable28
Signed-off-by: Luc Didry <luc@didry.org>
| -rw-r--r-- | apps/dav/lib/CalDAV/CalDavBackend.php | 47 |
1 files changed, 31 insertions, 16 deletions
diff --git a/apps/dav/lib/CalDAV/CalDavBackend.php b/apps/dav/lib/CalDAV/CalDavBackend.php index d4516f7f4a5..4cad081b5f8 100644 --- a/apps/dav/lib/CalDAV/CalDavBackend.php +++ b/apps/dav/lib/CalDAV/CalDavBackend.php @@ -99,6 +99,7 @@ use Sabre\VObject\ParseException; use Sabre\VObject\Property; use Sabre\VObject\Reader; use Sabre\VObject\Recur\EventIterator; +use Sabre\VObject\Recur\MaxInstancesExceededException; use Sabre\VObject\Recur\NoInstancesException; use function array_column; use function array_map; @@ -1711,6 +1712,12 @@ class CalDavBackend extends AbstractBackend implements SyncSupport, Subscription 'exception' => $ex, ]); continue; + } catch (MaxInstancesExceededException $ex) { + $this->logger->warning('Caught max instances exceeded exception for calendar data. This usually indicates too much recurring (more than 3500) event in calendar data. Object uri: '.$row['uri'], [ + 'app' => 'dav', + 'exception' => $ex, + ]); + continue; } if (!$matches) { @@ -2060,24 +2067,32 @@ class CalDavBackend extends AbstractBackend implements SyncSupport, Subscription continue; } - $isValid = $this->validateFilterForObject($row, [ - 'name' => 'VCALENDAR', - 'comp-filters' => [ - [ - 'name' => 'VEVENT', - 'comp-filters' => [], - 'prop-filters' => [], - 'is-not-defined' => false, - 'time-range' => [ - 'start' => $start, - 'end' => $end, + try { + $isValid = $this->validateFilterForObject($row, [ + 'name' => 'VCALENDAR', + 'comp-filters' => [ + [ + 'name' => 'VEVENT', + 'comp-filters' => [], + 'prop-filters' => [], + 'is-not-defined' => false, + 'time-range' => [ + 'start' => $start, + 'end' => $end, + ], ], ], - ], - 'prop-filters' => [], - 'is-not-defined' => false, - 'time-range' => null, - ]); + 'prop-filters' => [], + 'is-not-defined' => false, + 'time-range' => null, + ]); + } catch (MaxInstancesExceededException $ex) { + $this->logger->warning('Caught max instances exceeded exception for calendar data. This usually indicates too much recurring (more than 3500) event in calendar data. Object uri: '.$row['uri'], [ + 'app' => 'dav', + 'exception' => $ex, + ]); + continue; + } if (is_resource($row['calendardata'])) { // Put the stream back to the beginning so it can be read another time |