diff options
| author | Arthur Schiwon <blizzz@arthur-schiwon.de> | 2023-07-05 15:15:00 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-05 15:15:00 +0200 |
| commit | fc7944fc73109ec851acb04f2fc85d9c3423e3d3 (patch) | |
| tree | 1d07f4c6061be32211c576b636fd017d507ae0ac | |
| parent | 75a15dcfe4cf8a74a5e6fa170ad28d6176d1e34d (diff) | |
| parent | 29c0e078a1ed22644d1a0b31ec5693be100e38ad (diff) | |
| download | nextcloud-server-fc7944fc73109ec851acb04f2fc85d9c3423e3d3.tar.gz nextcloud-server-fc7944fc73109ec851acb04f2fc85d9c3423e3d3.zip | |
Merge pull request #39062 from nextcloud/fix/tag-search-short-circuit-master
fix(TagSearchProvider): Short circuit if no tag matches the query
| -rw-r--r-- | apps/systemtags/lib/Search/TagSearchProvider.php | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/apps/systemtags/lib/Search/TagSearchProvider.php b/apps/systemtags/lib/Search/TagSearchProvider.php index 7a7cb0b061c..5c731e42cc3 100644 --- a/apps/systemtags/lib/Search/TagSearchProvider.php +++ b/apps/systemtags/lib/Search/TagSearchProvider.php @@ -113,6 +113,11 @@ class TagSearchProvider implements IProvider { * @inheritDoc */ public function search(IUser $user, ISearchQuery $query): SearchResult { + $matchingTags = $this->tagManager->getAllTags(true, $query->getTerm()); + if (count($matchingTags) === 0) { + return SearchResult::complete($this->l10n->t('Tags'), []); + } + $userFolder = $this->rootFolder->getUserFolder($user->getUID()); $fileQuery = new SearchQuery( new SearchBinaryOperator(SearchBinaryOperator::OPERATOR_OR, [ @@ -133,7 +138,6 @@ class TagSearchProvider implements IProvider { return $node->getId(); }, $searchResults); $matchedTags = $this->objectMapper->getTagIdsForObjects($resultIds, 'files'); - $relevantTags = $this->tagManager->getTagsByIds(array_unique($this->flattenArray($matchedTags))); // prepare direct tag results $tagResults = array_map(function(ISystemTag $tag) { @@ -149,9 +153,7 @@ class TagSearchProvider implements IProvider { 'icon-tag' ); return $searchResultEntry; - }, array_filter($relevantTags, function($tag) use ($query) { - return $tag->isUserVisible() && strpos($tag->getName(), $query->getTerm()) !== false; - })); + }, $matchingTags); // prepare files results return SearchResult::paginated( |