diff options
author | John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> | 2020-10-20 13:58:01 +0200 |
---|---|---|
committer | John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> | 2021-03-22 06:40:41 +0100 |
commit | c8e0809d435e7ad90722be3d8a3304be73d95798 (patch) | |
tree | 05042a6f8eb5c786b1ebddb091f6dfc1f29f302d | |
parent | 100d5d9a4707dd7f5f6572d69dd55cb3d62b955f (diff) | |
download | nextcloud-server-c8e0809d435e7ad90722be3d8a3304be73d95798.tar.gz nextcloud-server-c8e0809d435e7ad90722be3d8a3304be73d95798.zip |
Extract GeneratePassword function to its own file
This is needed to be able to use the function from other components.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
-rw-r--r-- | apps/files_sharing/src/components/SharingEntryLink.vue | 39 | ||||
-rw-r--r-- | apps/files_sharing/src/utils/GeneratePassword.js | 56 |
2 files changed, 60 insertions, 35 deletions
diff --git a/apps/files_sharing/src/components/SharingEntryLink.vue b/apps/files_sharing/src/components/SharingEntryLink.vue index 982ed4bff3a..c214bc12503 100644 --- a/apps/files_sharing/src/components/SharingEntryLink.vue +++ b/apps/files_sharing/src/components/SharingEntryLink.vue @@ -324,7 +324,6 @@ <script> import { generateUrl } from '@nextcloud/router' -import axios from '@nextcloud/axios' import Vue from 'vue' import ActionButton from '@nextcloud/vue/dist/Components/ActionButton' @@ -338,11 +337,10 @@ import Actions from '@nextcloud/vue/dist/Components/Actions' import Avatar from '@nextcloud/vue/dist/Components/Avatar' import Tooltip from '@nextcloud/vue/dist/Directives/Tooltip' +import GeneratePassword from '../utils/GeneratePassword' import Share from '../models/Share' import SharesMixin from '../mixins/SharesMixin' -const passwordSet = 'abcdefgijkmnopqrstwxyzABCDEFGHJKLMNPQRSTWXYZ23456789' - export default { name: 'SharingEntryLink', @@ -491,7 +489,7 @@ export default { }, async set(enabled) { // TODO: directly save after generation to make sure the share is always protected - Vue.set(this.share, 'password', enabled ? await this.generatePassword() : '') + Vue.set(this.share, 'password', enabled ? await GeneratePassword() : '') Vue.set(this.share, 'newPassword', this.share.password) }, }, @@ -654,7 +652,7 @@ export default { shareDefaults.expiration = this.config.defaultExpirationDateString } if (this.config.enableLinkPasswordByDefault) { - shareDefaults.password = await this.generatePassword() + shareDefaults.password = await GeneratePassword() } // do not push yet if we need a password or an expiration date: show pending menu @@ -677,7 +675,7 @@ export default { // ELSE, show the pending popovermenu // if password enforced, pre-fill with random one if (this.config.enforcePasswordForPublicLink) { - shareDefaults.password = await this.generatePassword() + shareDefaults.password = await GeneratePassword() } // create share & close menu @@ -800,35 +798,6 @@ export default { this.queueUpdate('label') } }, - - /** - * Generate a valid policy password or - * request a valid password if password_policy - * is enabled - * - * @returns {string} a valid password - */ - async generatePassword() { - // password policy is enabled, let's request a pass - if (this.config.passwordPolicy.api && this.config.passwordPolicy.api.generate) { - try { - const request = await axios.get(this.config.passwordPolicy.api.generate) - if (request.data.ocs.data.password) { - return request.data.ocs.data.password - } - } catch (error) { - console.info('Error generating password from password_policy', error) - } - } - - // generate password of 10 length based on passwordSet - return Array(10).fill(0) - .reduce((prev, curr) => { - prev += passwordSet.charAt(Math.floor(Math.random() * passwordSet.length)) - return prev - }, '') - }, - async copyLink() { try { await this.$copyText(this.shareLink) diff --git a/apps/files_sharing/src/utils/GeneratePassword.js b/apps/files_sharing/src/utils/GeneratePassword.js new file mode 100644 index 00000000000..6e1a79f3f51 --- /dev/null +++ b/apps/files_sharing/src/utils/GeneratePassword.js @@ -0,0 +1,56 @@ + +/** + * @copyright Copyright (c) 2020 John Molakvoæ <skjnldsv@protonmail.com> + * + * @author John Molakvoæ <skjnldsv@protonmail.com> + * + * @license GNU AGPL version 3 or any later version + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +import axios from '@nextcloud/axios' +import Config from '../services/ConfigService' + +const config = new Config() +const passwordSet = 'abcdefgijkmnopqrstwxyzABCDEFGHJKLMNPQRSTWXYZ23456789' + +/** + * Generate a valid policy password or + * request a valid password if password_policy + * is enabled + * + * @returns {string} a valid password + */ +export default async function() { + // password policy is enabled, let's request a pass + if (config.passwordPolicy.api && config.passwordPolicy.api.generate) { + try { + const request = await axios.get(config.passwordPolicy.api.generate) + if (request.data.ocs.data.password) { + return request.data.ocs.data.password + } + } catch (error) { + console.info('Error generating password from password_policy', error) + } + } + + // generate password of 10 length based on passwordSet + return Array(10).fill(0) + .reduce((prev, curr) => { + prev += passwordSet.charAt(Math.floor(Math.random() * passwordSet.length)) + return prev + }, '') +} |