diff options
| author | Ferdinand Thiessen <opensource@fthiessen.de> | 2024-03-13 17:12:00 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-13 17:12:00 +0100 |
| commit | 078f51beeb89e885c841fe5067994e61c882ba1a (patch) | |
| tree | b070af66329aa39b51f2c32e815418d28540b751 | |
| parent | 5ea10a0c2934c0e0228dc39c49687252c51f66dd (diff) | |
| parent | 002fda62f17f60a59ce023f7fbe4d9d1e6a8905b (diff) | |
| download | nextcloud-server-078f51beeb89e885c841fe5067994e61c882ba1a.tar.gz nextcloud-server-078f51beeb89e885c841fe5067994e61c882ba1a.zip | |
Merge pull request #43334 from nextcloud/fix/array-access-on-boolean
fix(settings): `posix_getpwuid` can return `false` which should not be accessed like an array
| -rw-r--r-- | apps/settings/lib/Settings/Admin/Server.php | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/apps/settings/lib/Settings/Admin/Server.php b/apps/settings/lib/Settings/Admin/Server.php index d6d36432b42..dc6fc1cd350 100644 --- a/apps/settings/lib/Settings/Admin/Server.php +++ b/apps/settings/lib/Settings/Admin/Server.php @@ -56,13 +56,17 @@ class Server implements IDelegatedSettings { * @return TemplateResponse */ public function getForm() { + $ownerConfigFile = fileowner(\OC::$configDir . 'config.php'); + $cliBasedCronPossible = function_exists('posix_getpwuid') && $ownerConfigFile !== false; + $cliBasedCronUser = $cliBasedCronPossible ? (posix_getpwuid($ownerConfigFile)['name'] ?? '') : ''; + // Background jobs $this->initialStateService->provideInitialState('backgroundJobsMode', $this->config->getAppValue('core', 'backgroundjobs_mode', 'ajax')); $this->initialStateService->provideInitialState('lastCron', $this->appConfig->getValueInt('core', 'lastcron', 0)); $this->initialStateService->provideInitialState('cronMaxAge', $this->cronMaxAge()); $this->initialStateService->provideInitialState('cronErrors', $this->config->getAppValue('core', 'cronErrors')); - $this->initialStateService->provideInitialState('cliBasedCronPossible', function_exists('posix_getpwuid')); - $this->initialStateService->provideInitialState('cliBasedCronUser', function_exists('posix_getpwuid') ? posix_getpwuid(fileowner(\OC::$configDir . 'config.php'))['name'] : ''); + $this->initialStateService->provideInitialState('cliBasedCronPossible', $cliBasedCronPossible); + $this->initialStateService->provideInitialState('cliBasedCronUser', $cliBasedCronUser); $this->initialStateService->provideInitialState('backgroundJobsDocUrl', $this->urlGenerator->linkToDocs('admin-background-jobs')); // Profile page |