aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSebastianKrupinski <krupinskis05@gmail.com>2024-12-12 23:06:01 -0500
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>2024-12-13 17:35:12 +0000
commit2f46f9801b109e0ce4dd1ab1c95d748568b73415 (patch)
treebeb3a4fcd0d1f0757f2ccb1cef6265e1d99e0c37
parent0475b0c1b848d2b3860c571c8508fcddba35aae0 (diff)
downloadnextcloud-server-2f46f9801b109e0ce4dd1ab1c95d748568b73415.tar.gz
nextcloud-server-2f46f9801b109e0ce4dd1ab1c95d748568b73415.zip
fix: return 204 instead of 404backport/49839/stable30
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
-rw-r--r--apps/dav/lib/CardDAV/ImageExportPlugin.php2
-rw-r--r--apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php2
2 files changed, 2 insertions, 2 deletions
diff --git a/apps/dav/lib/CardDAV/ImageExportPlugin.php b/apps/dav/lib/CardDAV/ImageExportPlugin.php
index f8c2b6ee827..e2173db519b 100644
--- a/apps/dav/lib/CardDAV/ImageExportPlugin.php
+++ b/apps/dav/lib/CardDAV/ImageExportPlugin.php
@@ -91,7 +91,7 @@ class ImageExportPlugin extends ServerPlugin {
$response->setBody($file->getContent());
} catch (NotFoundException $e) {
- $response->setStatus(404);
+ $response->setStatus(\OCP\AppFramework\Http::STATUS_NO_CONTENT);
}
return false;
diff --git a/apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php b/apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php
index 6718153f910..cf6ddb1ff7b 100644
--- a/apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php
+++ b/apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php
@@ -171,7 +171,7 @@ class ImageExportPluginTest extends TestCase {
->willThrowException(new NotFoundException());
$this->response->expects($this->once())
->method('setStatus')
- ->with(404);
+ ->with(\OCP\AppFramework\Http::STATUS_NO_CONTENT);
}
$result = $this->plugin->httpGet($this->request, $this->response);