diff options
| author | Louis Chemineau <louis@chmn.me> | 2025-02-03 12:53:46 +0100 |
|---|---|---|
| committer | Louis Chemineau <louis@chmn.me> | 2025-03-03 16:15:24 +0100 |
| commit | 7588237dc001475b14063fae59c56e15b1b5f8ae (patch) | |
| tree | b61d50ca6fc5c286f73e146814ea8a80522dd300 | |
| parent | dfc5dee9ce26e80eedf0524ce26ddaf7b2dd21c4 (diff) | |
| download | nextcloud-server-backport/51050/stable29.tar.gz nextcloud-server-backport/51050/stable29.zip | |
fix: Report duplicated extra files in integrity checkbackport/51050/stable29
The `array_diff` is not comparing the array keys. This means that an extra key with an expected hash will not be reported. Using `array_diff_assoc` will report such files.
For example, copying `status.php` to `status 2.php`, will only be reported with the new version.
Signed-off-by: Louis Chemineau <louis@chmn.me>
| -rw-r--r-- | lib/private/IntegrityCheck/Checker.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/private/IntegrityCheck/Checker.php b/lib/private/IntegrityCheck/Checker.php index b17e4b1c0bf..32749a2c5f1 100644 --- a/lib/private/IntegrityCheck/Checker.php +++ b/lib/private/IntegrityCheck/Checker.php @@ -356,8 +356,8 @@ class Checker { // Compare the list of files which are not identical $currentInstanceHashes = $this->generateHashes($this->getFolderIterator($basePath), $basePath); - $differencesA = array_diff($expectedHashes, $currentInstanceHashes); - $differencesB = array_diff($currentInstanceHashes, $expectedHashes); + $differencesA = array_diff_assoc($expectedHashes, $currentInstanceHashes); + $differencesB = array_diff_assoc($currentInstanceHashes, $expectedHashes); $differences = array_unique(array_merge($differencesA, $differencesB)); $differenceArray = []; foreach ($differences as $filename => $hash) { |