aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCôme Chilliet <come.chilliet@nextcloud.com>2024-09-13 10:26:36 +0200
committerCôme Chilliet <come.chilliet@nextcloud.com>2024-09-13 10:26:36 +0200
commit7a16d01ea79bf8effedd5e0e9ac7c2e4b4ea41f8 (patch)
tree928eb9b44928e004c761f0fc31455ebf13486e85
parent76f2bc0bfc86a9d1ed34d37c574c7e7a327c0fab (diff)
downloadnextcloud-server-7a16d01ea79bf8effedd5e0e9ac7c2e4b4ea41f8.tar.gz
nextcloud-server-7a16d01ea79bf8effedd5e0e9ac7c2e4b4ea41f8.zip
chore(tests): Fix Router test by mocking AppManager methods correctly
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
-rw-r--r--tests/lib/Route/RouterTest.php14
1 files changed, 13 insertions, 1 deletions
diff --git a/tests/lib/Route/RouterTest.php b/tests/lib/Route/RouterTest.php
index 713d90d3c20..8647bb0f2f6 100644
--- a/tests/lib/Route/RouterTest.php
+++ b/tests/lib/Route/RouterTest.php
@@ -13,6 +13,7 @@ use OCP\App\IAppManager;
use OCP\Diagnostics\IEventLogger;
use OCP\IConfig;
use OCP\IRequest;
+use PHPUnit\Framework\MockObject\MockObject;
use Psr\Container\ContainerInterface;
use Psr\Log\LoggerInterface;
use Test\TestCase;
@@ -26,6 +27,8 @@ use Test\TestCase;
*/
class RouterTest extends TestCase {
private Router $router;
+ private IAppManager&MockObject $appManager;
+
protected function setUp(): void {
parent::setUp();
/** @var LoggerInterface $logger */
@@ -36,13 +39,16 @@ class RouterTest extends TestCase {
$this->fail('Unexpected info log: '.(string)($data['exception'] ?? $message));
}
);
+
+ $this->appManager = $this->createMock(IAppManager::class);
+
$this->router = new Router(
$logger,
$this->createMock(IRequest::class),
$this->createMock(IConfig::class),
$this->createMock(IEventLogger::class),
$this->createMock(ContainerInterface::class),
- $this->createMock(IAppManager::class),
+ $this->appManager,
);
}
@@ -51,6 +57,12 @@ class RouterTest extends TestCase {
}
public function testGenerateConsecutively(): void {
+ $this->appManager->expects(self::atLeastOnce())
+ ->method('cleanAppId')
+ ->willReturnArgument(0);
+ $this->appManager->expects(self::atLeastOnce())
+ ->method('getAppPath')
+ ->willReturnCallback(fn (string $appid): string => \OC::$SERVERROOT . '/apps/' . $appid);
$this->assertEquals('/index.php/apps/files/', $this->router->generate('files.view.index'));