aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Kesselberg <mail@danielkesselberg.de>2025-07-23 13:01:20 +0200
committerDaniel Kesselberg <mail@danielkesselberg.de>2025-07-23 13:08:54 +0200
commit4a571fc39193b0b78b8aae54fa8debed3a115464 (patch)
tree129693bf44ebb8985419aec8c38ac790a0fa840b
parent7268525a8a13807441280376f7ec70b6fcad2845 (diff)
downloadnextcloud-server-4a571fc39193b0b78b8aae54fa8debed3a115464.tar.gz
nextcloud-server-4a571fc39193b0b78b8aae54fa8debed3a115464.zip
style: enforce comma-dangle
The ESLint comma-dangle rule issues warnings but doesn't fail the CI. Running npm run lint:fix adds missing commas automatically. This often leads to committing unrelated changes. Now, the CI enforces the dangling comma rule. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
-rw-r--r--.eslintrc.js1
-rw-r--r--apps/dav/src/components/AbsenceForm.vue2
-rw-r--r--apps/dav/src/components/ExampleContentDownloadButton.vue4
-rw-r--r--apps/dav/src/settings-example-content.js2
-rw-r--r--apps/dav/src/views/ExampleContentSettingsSection.vue2
5 files changed, 6 insertions, 5 deletions
diff --git a/.eslintrc.js b/.eslintrc.js
index 23dc753f8b9..07941490c9c 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -22,6 +22,7 @@ module.exports = {
'plugin:cypress/recommended',
],
rules: {
+ 'comma-dangle': 'error',
'no-tabs': 'warn',
// TODO: make sure we fix this as this is bad vue coding style.
// Use proper sync modifier
diff --git a/apps/dav/src/components/AbsenceForm.vue b/apps/dav/src/components/AbsenceForm.vue
index 18c60ba4dd4..5350c04a565 100644
--- a/apps/dav/src/components/AbsenceForm.vue
+++ b/apps/dav/src/components/AbsenceForm.vue
@@ -219,7 +219,7 @@ export default {
lastDay: formatDateAsYMD(this.lastDay),
status: this.status,
message: this.message,
- replacementUserId: this.replacementUser?.user ?? null
+ replacementUserId: this.replacementUser?.user ?? null,
})
showSuccess(this.$t('dav', 'Absence saved'))
} catch (error) {
diff --git a/apps/dav/src/components/ExampleContentDownloadButton.vue b/apps/dav/src/components/ExampleContentDownloadButton.vue
index d3ee793eddc..6ee13e057bd 100644
--- a/apps/dav/src/components/ExampleContentDownloadButton.vue
+++ b/apps/dav/src/components/ExampleContentDownloadButton.vue
@@ -26,13 +26,13 @@ export default {
name: 'ExampleContentDownloadButton',
components: {
NcButton,
- IconDownload
+ IconDownload,
},
props: {
href: {
type: String,
required: true,
- }
+ },
},
}
</script>
diff --git a/apps/dav/src/settings-example-content.js b/apps/dav/src/settings-example-content.js
index ca0291ace4f..fdeba642a67 100644
--- a/apps/dav/src/settings-example-content.js
+++ b/apps/dav/src/settings-example-content.js
@@ -10,7 +10,7 @@ Vue.mixin({
methods: {
t: translate,
$t: translate,
- }
+ },
})
const View = Vue.extend(ExampleContentSettingsSection);
diff --git a/apps/dav/src/views/ExampleContentSettingsSection.vue b/apps/dav/src/views/ExampleContentSettingsSection.vue
index 5e65a1ba3b4..3ee2d9e8648 100644
--- a/apps/dav/src/views/ExampleContentSettingsSection.vue
+++ b/apps/dav/src/views/ExampleContentSettingsSection.vue
@@ -33,6 +33,6 @@ export default {
hasCalendarApp() {
return loadState('dav', 'calendarEnabled')
},
- }
+ },
}
</script>