diff options
| author | Daniel Kesselberg <mail@danielkesselberg.de> | 2025-04-09 18:24:49 +0200 |
|---|---|---|
| committer | Daniel Kesselberg <mail@danielkesselberg.de> | 2025-04-15 13:20:37 +0200 |
| commit | fa8b389b6e45918ea4d59b91a0fbbcc244565a6c (patch) | |
| tree | f1e6c36a345276cb5257e38ee892be57efa010bb | |
| parent | e5b34b700debe5f47bc413c29a746c033a06d641 (diff) | |
| download | nextcloud-server-fa8b389b6e45918ea4d59b91a0fbbcc244565a6c.tar.gz nextcloud-server-fa8b389b6e45918ea4d59b91a0fbbcc244565a6c.zip | |
ci: add check to ensure composer-bin is not accidentally committed
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
| -rw-r--r-- | .github/workflows/autocheckers.yml | 4 | ||||
| -rwxr-xr-x | build/autoloaderchecker.sh | 7 |
2 files changed, 8 insertions, 3 deletions
diff --git a/.github/workflows/autocheckers.yml b/.github/workflows/autocheckers.yml index 75f9f62d80e..571970cb903 100644 --- a/.github/workflows/autocheckers.yml +++ b/.github/workflows/autocheckers.yml @@ -36,6 +36,7 @@ jobs: - 'composer.json' - 'composer.lock' - '**.php' + - build/autoloaderchecker.sh autoloader: runs-on: ubuntu-latest @@ -66,9 +67,6 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Set up dependencies - run: composer i - - name: Check auto loaders run: bash ./build/autoloaderchecker.sh diff --git a/build/autoloaderchecker.sh b/build/autoloaderchecker.sh index 7d8fd98cd60..75db26f07ce 100755 --- a/build/autoloaderchecker.sh +++ b/build/autoloaderchecker.sh @@ -34,6 +34,13 @@ echo echo "Regenerating main autoloader" $COMPOSER_COMMAND dump-autoload -d $REPODIR +FOUND_COMPOSER_BIN=$(grep --recursive --fixed-strings 'Bamarni\\Composer\\Bin' $REPODIR/lib/composer/composer/) +if [ -n "$FOUND_COMPOSER_BIN" ]; then + echo "The main autoloader contains the composer bin plugin" + echo "Run composer again with --no-dev and commit the result" + exit 1 +fi + for app in ${REPODIR}/apps/*; do if git check-ignore ${app} -q ; then echo |