diff options
| author | Julius Härtl <jus@bitgrid.net> | 2023-02-09 13:41:13 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-09 13:41:13 +0100 |
| commit | dd891e7e8128bfd888a9451514db3c1b82b1a9cc (patch) | |
| tree | 5fc7a092afdc078dcae8bf1f2ef3a0d77ef35332 | |
| parent | 06f0da6d46e360c8ec08bbbf906515e84009e768 (diff) | |
| parent | 7b413a41eb1e937783032e98fd918a1e1ac8ce6d (diff) | |
| download | nextcloud-server-dd891e7e8128bfd888a9451514db3c1b82b1a9cc.tar.gz nextcloud-server-dd891e7e8128bfd888a9451514db3c1b82b1a9cc.zip | |
Merge pull request #36626 from nextcloud/perf/dav-auth-setupfs
| -rw-r--r-- | apps/dav/lib/Connector/Sabre/Auth.php | 3 | ||||
| -rw-r--r-- | apps/dav/tests/unit/Connector/Sabre/AuthTest.php | 12 |
2 files changed, 6 insertions, 9 deletions
diff --git a/apps/dav/lib/Connector/Sabre/Auth.php b/apps/dav/lib/Connector/Sabre/Auth.php index 1610c554b9b..69821c63c21 100644 --- a/apps/dav/lib/Connector/Sabre/Auth.php +++ b/apps/dav/lib/Connector/Sabre/Auth.php @@ -104,14 +104,11 @@ class Auth extends AbstractBasic { if ($this->userSession->isLoggedIn() && $this->isDavAuthenticated($this->userSession->getUser()->getUID()) ) { - \OC_Util::setupFS($this->userSession->getUser()->getUID()); $this->session->close(); return true; } else { - \OC_Util::setupFS(); //login hooks may need early access to the filesystem try { if ($this->userSession->logClientIn($username, $password, $this->request, $this->throttler)) { - \OC_Util::setupFS($this->userSession->getUser()->getUID()); $this->session->set(self::DAV_AUTHENTICATED, $this->userSession->getUser()->getUID()); $this->session->close(); return true; diff --git a/apps/dav/tests/unit/Connector/Sabre/AuthTest.php b/apps/dav/tests/unit/Connector/Sabre/AuthTest.php index 72800b84253..be841295f0b 100644 --- a/apps/dav/tests/unit/Connector/Sabre/AuthTest.php +++ b/apps/dav/tests/unit/Connector/Sabre/AuthTest.php @@ -117,7 +117,7 @@ class AuthTest extends TestCase { $user = $this->getMockBuilder(IUser::class) ->disableOriginalConstructor() ->getMock(); - $user->expects($this->exactly(2)) + $user->expects($this->exactly(1)) ->method('getUID') ->willReturn('MyTestUser'); $this->userSession @@ -125,7 +125,7 @@ class AuthTest extends TestCase { ->method('isLoggedIn') ->willReturn(true); $this->userSession - ->expects($this->exactly(2)) + ->expects($this->exactly(1)) ->method('getUser') ->willReturn($user); $this->session @@ -171,7 +171,7 @@ class AuthTest extends TestCase { $user = $this->getMockBuilder(IUser::class) ->disableOriginalConstructor() ->getMock(); - $user->expects($this->exactly(3)) + $user->expects($this->exactly(2)) ->method('getUID') ->willReturn('MyTestUser'); $this->userSession @@ -179,7 +179,7 @@ class AuthTest extends TestCase { ->method('isLoggedIn') ->willReturn(true); $this->userSession - ->expects($this->exactly(3)) + ->expects($this->exactly(2)) ->method('getUser') ->willReturn($user); $this->session @@ -660,11 +660,11 @@ class AuthTest extends TestCase { $user = $this->getMockBuilder(IUser::class) ->disableOriginalConstructor() ->getMock(); - $user->expects($this->exactly(3)) + $user->expects($this->exactly(2)) ->method('getUID') ->willReturn('MyTestUser'); $this->userSession - ->expects($this->exactly(4)) + ->expects($this->exactly(3)) ->method('getUser') ->willReturn($user); $response = $this->auth->check($server->httpRequest, $server->httpResponse); |