diff options
| author | Côme Chilliet <come.chilliet@nextcloud.com> | 2025-03-06 16:36:47 +0100 |
|---|---|---|
| committer | Côme Chilliet <91878298+come-nc@users.noreply.github.com> | 2025-03-10 11:30:18 +0100 |
| commit | c59400dea135279a59dd58530d28558e5bc9a97b (patch) | |
| tree | 9f89fc493d017077e2eeb0e704ab1331d8409143 | |
| parent | 30382a5d8d14569cd217f19e92471da1925ea9de (diff) | |
| download | nextcloud-server-fix/fix-disabled-user-list-for-saml-subadmin.tar.gz nextcloud-server-fix/fix-disabled-user-list-for-saml-subadmin.zip | |
chore: Move magic number into a documented constfix/fix-disabled-user-list-for-saml-subadmin
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| -rw-r--r-- | apps/settings/lib/Controller/UsersController.php | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/apps/settings/lib/Controller/UsersController.php b/apps/settings/lib/Controller/UsersController.php index d0e1cc2ba3d..739943d91b0 100644 --- a/apps/settings/lib/Controller/UsersController.php +++ b/apps/settings/lib/Controller/UsersController.php @@ -55,6 +55,8 @@ use function in_array; #[OpenAPI(scope: OpenAPI::SCOPE_IGNORE)] class UsersController extends Controller { + /** Limit for counting users for subadmins, to avoid spending too much time */ + private const COUNT_LIMIT_FOR_SUBADMINS = 999; public function __construct( string $appName, @@ -152,7 +154,7 @@ class UsersController extends Controller { }, 0); } else { // User is subadmin ! - [$userCount,$disabledUsers] = $this->userManager->countUsersAndDisabledUsersOfGroups($groupsInfo->getGroups(), 999); + [$userCount,$disabledUsers] = $this->userManager->countUsersAndDisabledUsersOfGroups($groupsInfo->getGroups(), self::COUNT_LIMIT_FOR_SUBADMINS); } if ($disabledUsers > 0) { |