Merge pull request #49588 from nextcloud/bugfix/noid/make-the-cache-check-use-it

fix(setupcheck): Make the Memcache setupcheck use the cache

1 files changed, 37 insertions, 0 deletions

diff --git a/apps/settings/lib/SetupChecks/MemcacheConfigured.php b/apps/settings/lib/SetupChecks/MemcacheConfigured.php
index d42b0f67298..65151591fbf 100644
--- a/apps/settings/lib/SetupChecks/MemcacheConfigured.php
+++ b/apps/settings/lib/SetupChecks/MemcacheConfigured.php
@@ -9,6 +9,7 @@ declare(strict_types=1);
 namespace OCA\Settings\SetupChecks;
 
 use OC\Memcache\Memcached;
+use OCP\ICacheFactory;
 use OCP\IConfig;
 use OCP\IL10N;
 use OCP\IURLGenerator;
@@ -20,6 +21,7 @@ class MemcacheConfigured implements ISetupCheck {
 		private IL10N $l10n,
 		private IConfig $config,
 		private IURLGenerator $urlGenerator,
+		private ICacheFactory $cacheFactory,
 	) {
 	}
 
@@ -56,6 +58,41 @@ class MemcacheConfigured implements ISetupCheck {
 				$this->urlGenerator->linkToDocs('admin-performance')
 			);
 		}
+
+		if ($this->cacheFactory->isLocalCacheAvailable()) {
+			$random = random_bytes(64);
+			$local = $this->cacheFactory->createLocal('setupcheck.local');
+			try {
+				$local->set('test', $random);
+				$local2 = $this->cacheFactory->createLocal('setupcheck.local');
+				$actual = $local2->get('test');
+				$local->remove('test');
+			} catch (\Throwable) {
+				$actual = null;
+			}
+
+			if ($actual !== $random) {
+				return SetupResult::error($this->l10n->t('Failed to write and read a value from local cache.'));
+			}
+		}
+
+		if ($this->cacheFactory->isAvailable()) {
+			$random = random_bytes(64);
+			$distributed = $this->cacheFactory->createDistributed('setupcheck');
+			try {
+				$distributed->set('test', $random);
+				$distributed2 = $this->cacheFactory->createDistributed('setupcheck');
+				$actual = $distributed2->get('test');
+				$distributed->remove('test');
+			} catch (\Throwable) {
+				$actual = null;
+			}
+
+			if ($actual !== $random) {
+				return SetupResult::error($this->l10n->t('Failed to write and read a value from distributed cache.'));
+			}
+		}
+
 		return SetupResult::success($this->l10n->t('Configured'));
 	}
 }