fix(files_versions): only close stream if still open, fixing S3fix/s3-versions

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

1 files changed, 7 insertions, 1 deletions

diff --git a/apps/files_versions/lib/Storage.php b/apps/files_versions/lib/Storage.php
index 4b58d721583..0fb3a0522f4 100644
--- a/apps/files_versions/lib/Storage.php
+++ b/apps/files_versions/lib/Storage.php
@@ -430,11 +430,17 @@ class Storage {
 					} else {
 						$target = $storage2->fopen($internalPath2, 'w');
 						$result = $target !== false;
-						if ($target !== false) {
+						if ($result) {
 							[, $result] = Files::streamCopy($source, $target, true);
+						}
+						// explicit check as S3 library closes streams already
+						if (is_resource($target)) {
 							fclose($target);
 						}
 					}
+				}
+				// explicit check as S3 library closes streams already
+				if (is_resource($source)) {
 					fclose($source);
 				}