aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoeland Jago Douma <rullzer@owncloud.com>2015-12-18 13:42:59 +0100
committerRoeland Jago Douma <rullzer@owncloud.com>2015-12-18 13:42:59 +0100
commit4f20e3bac0dec72ede10f947ee3d1125071d4564 (patch)
tree36c27fcc686d457f3f8cc3f34fce2a760b0ad525
parentb4a896c00ddfbd7c3965a4d9c9b723b6fe915103 (diff)
downloadnextcloud-server-4f20e3bac0dec72ede10f947ee3d1125071d4564.tar.gz
nextcloud-server-4f20e3bac0dec72ede10f947ee3d1125071d4564.zip
Removed deprecated OC_Helper::getSecureMimeType
-rw-r--r--apps/dav/lib/connector/sabre/file.php2
-rw-r--r--apps/files/download.php2
-rw-r--r--apps/files_versions/download.php2
-rw-r--r--lib/private/helper.php11
-rw-r--r--tests/lib/helper.php12
5 files changed, 3 insertions, 26 deletions
diff --git a/apps/dav/lib/connector/sabre/file.php b/apps/dav/lib/connector/sabre/file.php
index c66f627c0a3..6a0a39d04e7 100644
--- a/apps/dav/lib/connector/sabre/file.php
+++ b/apps/dav/lib/connector/sabre/file.php
@@ -329,7 +329,7 @@ class File extends Node implements IFile {
if (isset($_SERVER['REQUEST_METHOD']) && $_SERVER['REQUEST_METHOD'] === 'PROPFIND') {
return $mimeType;
}
- return \OC_Helper::getSecureMimeType($mimeType);
+ return \OC::$server->getMimeTypeDetector()->getSecureMimeType($mimeType);
}
/**
diff --git a/apps/files/download.php b/apps/files/download.php
index b0628e394be..b058f0ebf5b 100644
--- a/apps/files/download.php
+++ b/apps/files/download.php
@@ -39,7 +39,7 @@ if(!\OC\Files\Filesystem::file_exists($filename)) {
exit;
}
-$ftype=\OC_Helper::getSecureMimeType(\OC\Files\Filesystem::getMimeType( $filename ));
+$ftype=\OC::$server->getMimeTypeDetector()->getSecureMimeType(\OC\Files\Filesystem::getMimeType( $filename ));
header('Content-Type:'.$ftype);
OCP\Response::setContentDispositionHeader(basename($filename), 'attachment');
diff --git a/apps/files_versions/download.php b/apps/files_versions/download.php
index 22a218f472a..d3c38f3d4e1 100644
--- a/apps/files_versions/download.php
+++ b/apps/files_versions/download.php
@@ -35,7 +35,7 @@ $versionName = '/'.$uid.'/files_versions/'.$filename.'.v'.$revision;
$view = new OC\Files\View('/');
-$ftype = \OC_Helper::getSecureMimeType($view->getMimeType('/'.$uid.'/files/'.$filename));
+$ftype = \OC::$server->getMimeTypeDetector()->getSecureMimeType($view->getMimeType('/'.$uid.'/files/'.$filename));
header('Content-Type:'.$ftype);
OCP\Response::setContentDispositionHeader(basename($filename), 'attachment');
diff --git a/lib/private/helper.php b/lib/private/helper.php
index c6223d2147a..29ecd85388f 100644
--- a/lib/private/helper.php
+++ b/lib/private/helper.php
@@ -347,17 +347,6 @@ class OC_Helper {
}
/**
- * Get a secure mimetype that won't expose potential XSS.
- *
- * @param string $mimeType
- * @return string
- * @deprecated 8.2.0 Use \OC::$server->getMimeTypeDetector()->getSecureMimeType($mimeType)
- */
- static function getSecureMimeType($mimeType) {
- return \OC::$server->getMimeTypeDetector()->getSecureMimeType($mimeType);
- }
-
- /**
* get the mimetype form a data string
*
* @param string $data
diff --git a/tests/lib/helper.php b/tests/lib/helper.php
index 9ad3af3d60c..576209df06b 100644
--- a/tests/lib/helper.php
+++ b/tests/lib/helper.php
@@ -71,18 +71,6 @@ class Test_Helper extends \Test\TestCase {
];
}
- function testGetSecureMimeType() {
- $dir=OC::$SERVERROOT.'/tests/data';
-
- $result = OC_Helper::getSecureMimeType('image/svg+xml');
- $expected = 'text/plain';
- $this->assertEquals($result, $expected);
-
- $result = OC_Helper::getSecureMimeType('image/png');
- $expected = 'image/png';
- $this->assertEquals($result, $expected);
- }
-
function testGetStringMimeType() {
if (\OC_Util::runningOnWindows()) {
$this->markTestSkipped('[Windows] Strings have mimetype application/octet-stream on Windows');