Merge pull request #19465 from nextcloud/enh/noid/empty-whatsnew

when we receive intentional empty whats new info, do not try to show it

2 files changed, 9 insertions, 1 deletions

diff --git a/lib/private/Updater/ChangesCheck.php b/lib/private/Updater/ChangesCheck.php
index f1f44cc59c8..7346ceab6b1 100644
--- a/lib/private/Updater/ChangesCheck.php
+++ b/lib/private/Updater/ChangesCheck.php
@@ -55,7 +55,11 @@ class ChangesCheck {
 	public function getChangesForVersion(string $version): array {
 		$version = $this->normalizeVersion($version);
 		$changesInfo = $this->mapper->getChanges($version);
-		return json_decode($changesInfo->getData(), true);
+		$changesData = json_decode($changesInfo->getData(), true);
+		if(empty($changesData)) {
+			throw new DoesNotExistException();
+		}
+		return $changesData;
 	}
 
 	/**
diff --git a/tests/lib/Updater/ChangesCheckTest.php b/tests/lib/Updater/ChangesCheckTest.php
index a979007573d..30cb9df2956 100644
--- a/tests/lib/Updater/ChangesCheckTest.php
+++ b/tests/lib/Updater/ChangesCheckTest.php
@@ -279,6 +279,10 @@ class ChangesCheckTest extends TestCase {
 					],
 				]
 			],
+			[ # 4 - empty
+				'',
+				[]
+			],
 		];
 	}