aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoeland Jago Douma <rullzer@users.noreply.github.com>2018-08-09 19:49:47 +0200
committerGitHub <noreply@github.com>2018-08-09 19:49:47 +0200
commitf630b12fc78c2201504fc14a2b8dec2c610655b2 (patch)
tree763df9d7d7da46d8b9a257bfdf01ef6ca5aba8f9
parent7dc4fadc218da461834ac161dd683a03f89db2bb (diff)
parent8c1e75e0520d0efe51b615952329b1980d21f8b6 (diff)
downloadnextcloud-server-f630b12fc78c2201504fc14a2b8dec2c610655b2.tar.gz
nextcloud-server-f630b12fc78c2201504fc14a2b8dec2c610655b2.zip
Merge pull request #10614 from nextcloud/bugfix/noid/fix_including_invalid_file
Do not use file as template parameter
-rw-r--r--core/templates/403.php2
-rw-r--r--lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php2
-rw-r--r--tests/lib/AppFramework/Middleware/Security/SecurityMiddlewareTest.php2
3 files changed, 3 insertions, 3 deletions
diff --git a/core/templates/403.php b/core/templates/403.php
index e053fad764a..72d5d3e4ae6 100644
--- a/core/templates/403.php
+++ b/core/templates/403.php
@@ -12,6 +12,6 @@ if(!isset($_)) {//standalone page is not supported anymore - redirect to /
<ul>
<li class='error'>
<?php p($l->t( 'Access forbidden' )); ?><br>
- <p class='hint'><?php if(isset($_['file'])) p($_['file'])?></p>
+ <p class='hint'><?php if(isset($_['message'])) p($_['message'])?></p>
</li>
</ul>
diff --git a/lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php b/lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php
index 2eedc39c3ab..87954ccc1cb 100644
--- a/lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php
+++ b/lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php
@@ -249,7 +249,7 @@ class SecurityMiddleware extends Middleware {
$url = $this->urlGenerator->linkToRoute('core.login.showLoginForm', $params);
$response = new RedirectResponse($url);
} else {
- $response = new TemplateResponse('core', '403', ['file' => $exception->getMessage()], 'guest');
+ $response = new TemplateResponse('core', '403', ['message' => $exception->getMessage()], 'guest');
$response->setStatus($exception->getCode());
}
}
diff --git a/tests/lib/AppFramework/Middleware/Security/SecurityMiddlewareTest.php b/tests/lib/AppFramework/Middleware/Security/SecurityMiddlewareTest.php
index f51f7e9a1c6..13c5379b142 100644
--- a/tests/lib/AppFramework/Middleware/Security/SecurityMiddlewareTest.php
+++ b/tests/lib/AppFramework/Middleware/Security/SecurityMiddlewareTest.php
@@ -568,7 +568,7 @@ class SecurityMiddlewareTest extends \Test\TestCase {
'test',
$exception
);
- $expected = new TemplateResponse('core', '403', ['file' => $exception->getMessage()], 'guest');
+ $expected = new TemplateResponse('core', '403', ['message' => $exception->getMessage()], 'guest');
$expected->setStatus($exception->getCode());
$this->assertEquals($expected , $response);
}