diff options
| author | Côme Chilliet <come.chilliet@nextcloud.com> | 2024-04-29 13:56:18 +0200 |
|---|---|---|
| committer | Côme Chilliet <come.chilliet@nextcloud.com> | 2024-04-30 09:23:59 +0200 |
| commit | 37262c860a5c455a01c386ceb302752d37d0b217 (patch) | |
| tree | cce67d58a1ec75932e4778cc3da536423ab6c57d | |
| parent | 4c27e88b404ecdcaca8995057c251925c84d6137 (diff) | |
| download | nextcloud-server-37262c860a5c455a01c386ceb302752d37d0b217.tar.gz nextcloud-server-37262c860a5c455a01c386ceb302752d37d0b217.zip | |
fix(setupchecks): Fix opcache buffer check
This was broken by last codestyle update, maybe even before because of
operator precedence. Now using vars to make it readable and correct at
the same time.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| -rw-r--r-- | apps/settings/lib/SetupChecks/PhpOpcacheSetup.php | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/apps/settings/lib/SetupChecks/PhpOpcacheSetup.php b/apps/settings/lib/SetupChecks/PhpOpcacheSetup.php index c6f5c9802ca..a89916f5edb 100644 --- a/apps/settings/lib/SetupChecks/PhpOpcacheSetup.php +++ b/apps/settings/lib/SetupChecks/PhpOpcacheSetup.php @@ -102,9 +102,11 @@ class PhpOpcacheSetup implements ISetupCheck { $recommendations[] = $this->l10n->t('The OPcache buffer is nearly full. To assure that all scripts can be hold in cache, it is recommended to apply "opcache.memory_consumption" to your PHP configuration with a value higher than "%s".', [($this->iniGetWrapper->getNumeric('opcache.memory_consumption') ?: 'currently')]); } + $interned_strings_buffer = $this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') ?? 0; + $memory_consumption = $this->iniGetWrapper->getNumeric('opcache.memory_consumption') ?? 0; if ( // Do not recommend to raise the interned strings buffer size above a quarter of the total OPcache size - ($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') ?? $this->iniGetWrapper->getNumeric('opcache.memory_consumption') > 0 ?? 0 / 4) && + ($interned_strings_buffer < ($memory_consumption / 4)) && ( empty($status['interned_strings_usage']['free_memory']) || ($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) |