aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoas Schilling <coding@schilljs.com>2019-04-30 12:08:22 +0200
committerJoas Schilling <coding@schilljs.com>2019-07-15 15:14:58 +0200
commit64f67818bcc6cc61cc49b1a7c032f3db85b73c91 (patch)
treef17e3c44ce81a94e4cf9d0f941a0002011b4f1a3
parent865c12aa0e624d21d15b351ee5fcbedffa55f11c (diff)
downloadnextcloud-server-64f67818bcc6cc61cc49b1a7c032f3db85b73c91.tar.gz
nextcloud-server-64f67818bcc6cc61cc49b1a7c032f3db85b73c91.zip
Fix new core notifier
Signed-off-by: Joas Schilling <coding@schilljs.com>
-rw-r--r--core/Application.php20
-rw-r--r--core/Notification/RemoveLinkSharesNotifier.php23
-rw-r--r--lib/private/Authentication/Notifications/Notifier.php21
3 files changed, 43 insertions, 21 deletions
diff --git a/core/Application.php b/core/Application.php
index 9655a8e1a47..3a212f85472 100644
--- a/core/Application.php
+++ b/core/Application.php
@@ -65,24 +65,8 @@ class Application extends App {
$eventDispatcher = $server->query(IEventDispatcher::class);
$notificationManager = $server->getNotificationManager();
- $notificationManager->registerNotifier(function () use ($server) {
- return new RemoveLinkSharesNotifier(
- $server->getL10NFactory()
- );
- }, function () {
- return [
- 'id' => 'core',
- 'name' => 'core',
- ];
- });
- $notificationManager->registerNotifier(function () use ($server) {
- return $server->query(AuthenticationNotifier::class);
- }, function () {
- return [
- 'id' => 'auth',
- 'name' => 'authentication notifier',
- ];
- });
+ $notificationManager->registerNotifier(RemoveLinkSharesNotifier::class);
+ $notificationManager->registerNotifier(AuthenticationNotifier::class);
$eventDispatcher->addListener(IDBConnection::CHECK_MISSING_INDEXES_EVENT,
function (GenericEvent $event) use ($container) {
diff --git a/core/Notification/RemoveLinkSharesNotifier.php b/core/Notification/RemoveLinkSharesNotifier.php
index b77846c847e..b2e73aee237 100644
--- a/core/Notification/RemoveLinkSharesNotifier.php
+++ b/core/Notification/RemoveLinkSharesNotifier.php
@@ -36,7 +36,27 @@ class RemoveLinkSharesNotifier implements INotifier {
$this->l10nFactory = $factory;
}
- public function prepare(INotification $notification, $languageCode): INotification {
+ /**
+ * Identifier of the notifier, only use [a-z0-9_]
+ *
+ * @return string
+ * @since 17.0.0
+ */
+ public function getID(): string {
+ return 'core';
+ }
+
+ /**
+ * Human readable name describing the notifier
+ *
+ * @return string
+ * @since 17.0.0
+ */
+ public function getName(): string {
+ return $this->l10nFactory->get('core')->t('Nextcloud Server');
+ }
+
+ public function prepare(INotification $notification, string $languageCode): INotification {
if($notification->getApp() !== 'core') {
throw new \InvalidArgumentException();
}
@@ -51,5 +71,4 @@ class RemoveLinkSharesNotifier implements INotifier {
throw new \InvalidArgumentException('Invalid subject');
}
-
}
diff --git a/lib/private/Authentication/Notifications/Notifier.php b/lib/private/Authentication/Notifications/Notifier.php
index 0aafc115b22..f76bb077a3c 100644
--- a/lib/private/Authentication/Notifications/Notifier.php
+++ b/lib/private/Authentication/Notifications/Notifier.php
@@ -42,7 +42,7 @@ class Notifier implements INotifier {
/**
* @inheritDoc
*/
- public function prepare(INotification $notification, $languageCode) {
+ public function prepare(INotification $notification, string $languageCode): INotification {
if ($notification->getApp() !== 'auth') {
// Not my app => throw
throw new InvalidArgumentException();
@@ -74,4 +74,23 @@ class Notifier implements INotifier {
}
}
+ /**
+ * Identifier of the notifier, only use [a-z0-9_]
+ *
+ * @return string
+ * @since 17.0.0
+ */
+ public function getID(): string {
+ return 'auth';
+ }
+
+ /**
+ * Human readable name describing the notifier
+ *
+ * @return string
+ * @since 17.0.0
+ */
+ public function getName(): string {
+ return $this->factory->get('lib')->t('Authentication');
+ }
}