aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCôme Chilliet <come.chilliet@nextcloud.com>2023-08-07 11:32:27 +0200
committerCôme Chilliet <come.chilliet@nextcloud.com>2023-08-10 10:57:36 +0200
commit7732de75eeea0f549bb65378f33a05d2aa1a38db (patch)
tree13c1c5b3ac7aa9a69cae9d465ae809e66e3f03fb
parentad1e487f67dd300eaddbe4d998d04ccbbca0921f (diff)
downloadnextcloud-server-7732de75eeea0f549bb65378f33a05d2aa1a38db.tar.gz
nextcloud-server-7732de75eeea0f549bb65378f33a05d2aa1a38db.zip
Removed GroupCreatedEvent/GroupDeletedEvent from UpdateGroupsService
This should be handled when mapping groups, not when registering their members. An empty group may still exist. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
-rw-r--r--apps/user_ldap/lib/Service/UpdateGroupsService.php6
1 files changed, 0 insertions, 6 deletions
diff --git a/apps/user_ldap/lib/Service/UpdateGroupsService.php b/apps/user_ldap/lib/Service/UpdateGroupsService.php
index ea707c7c9d8..faee092a372 100644
--- a/apps/user_ldap/lib/Service/UpdateGroupsService.php
+++ b/apps/user_ldap/lib/Service/UpdateGroupsService.php
@@ -38,7 +38,6 @@ use OCA\User_LDAP\Db\GroupMembershipMapper;
use OCA\User_LDAP\Group_Proxy;
use OCP\DB\Exception;
use OCP\EventDispatcher\IEventDispatcher;
-use OCP\Group\Events\GroupCreatedEvent;
use OCP\Group\Events\UserAddedEvent;
use OCP\Group\Events\UserRemovedEvent;
use OCP\IGroup;
@@ -151,9 +150,6 @@ class UpdateGroupsService {
$users = $this->groupBackend->usersInGroup($createdGroup);
$groupObject = $this->groupManager->get($createdGroup);
- if ($groupObject instanceof IGroup) {
- $this->dispatcher->dispatchTyped(new GroupCreatedEvent($groupObject));
- }
foreach ($users as $user) {
$this->groupMembershipMapper->insert(GroupMembership::fromParams(['groupid' => $createdGroup,'userid' => $user]));
if ($groupObject instanceof IGroup) {
@@ -188,8 +184,6 @@ class UpdateGroupsService {
}
}
- //TODO find a way to dispatch GroupDeletedEvent
-
$this->logger->info(
'service "updateGroups" – groups {removedGroups} were removed.',
[