diff options
| author | Daniel Calviño Sánchez <danxuliu@gmail.com> | 2021-03-05 21:57:47 +0100 |
|---|---|---|
| committer | Daniel Calviño Sánchez <danxuliu@gmail.com> | 2021-03-06 01:34:43 +0100 |
| commit | 78faf0105de775e9ac49fb85ed36f5bbfac290f0 (patch) | |
| tree | 164e73eb5b933b3f602cdf702625fa00069944e8 | |
| parent | f87473e410258fb24ca1391783ec1bc8bf759e9e (diff) | |
| download | nextcloud-server-78faf0105de775e9ac49fb85ed36f5bbfac290f0.tar.gz nextcloud-server-78faf0105de775e9ac49fb85ed36f5bbfac290f0.zip | |
Add explicit locator for "Enable all" bundle button
Instead of looking for the bundle button and then checking its value now
the expected value is included in the locator and the button is checked
similarly to other elements.
No "Disable all" locator was added as it was not currently needed
anywhere.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| -rw-r--r-- | tests/acceptance/features/bootstrap/AppsManagementContext.php | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/tests/acceptance/features/bootstrap/AppsManagementContext.php b/tests/acceptance/features/bootstrap/AppsManagementContext.php index 56ec7c6b85f..82d4561bd28 100644 --- a/tests/acceptance/features/bootstrap/AppsManagementContext.php +++ b/tests/acceptance/features/bootstrap/AppsManagementContext.php @@ -84,10 +84,10 @@ class AppsManagementContext implements Context, ActorAwareInterface { /** * @return Locator */ - public static function bundleButton($bundle) { - return Locator::forThe()->xpath("//div[@class='apps-header']/h2[normalize-space() = '$bundle']/input")-> + public static function enableAllBundleButton($bundle) { + return Locator::forThe()->xpath("//div[@class='apps-header']/h2[normalize-space() = '$bundle']/input[@value='Enable all']")-> descendantOf(self::appsList())-> - describedAs("Button to enable / disable bundles"); + describedAs("Button to enable bundles"); } /** @@ -245,14 +245,16 @@ class AppsManagementContext implements Context, ActorAwareInterface { * @When /^I enable all apps from the "([^"]*)"$/ */ public function iEnableAllAppsFromThe($bundle) { - $this->actor->find(self::bundleButton($bundle), 2)->click(); + $this->actor->find(self::enableAllBundleButton($bundle), 2)->click(); } /** * @Given /^I see that the "([^"]*)" is disabled$/ */ public function iSeeThatTheIsDisabled($bundle) { - PHPUnit\Framework\Assert::assertEquals('Enable all', $this->actor->find(self::bundleButton($bundle), 2)->getValue()); + PHPUnit_Framework_Assert::assertTrue( + $this->actor->find(self::enableAllBundleButton($bundle), 2)->isVisible() + ); } /** |