diff options
author | Morris Jobke <hey@morrisjobke.de> | 2017-11-09 09:24:35 +0100 |
---|---|---|
committer | Morris Jobke <hey@morrisjobke.de> | 2017-11-09 09:27:38 +0100 |
commit | a0aef6ab1b7e0af45c706073285f06925bdb237b (patch) | |
tree | 1ad1c28b18311ff6ba33085f7a41319f3bf68620 | |
parent | aa525d89e889216d17185a6934699a8f8ba7aa91 (diff) | |
download | nextcloud-server-a0aef6ab1b7e0af45c706073285f06925bdb237b.tar.gz nextcloud-server-a0aef6ab1b7e0af45c706073285f06925bdb237b.zip |
Fix welcome text for better grammar in themed instances
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
-rw-r--r-- | lib/public/Mail/IEMailTemplate.php | 2 | ||||
-rw-r--r-- | settings/Mailer/NewUserMailHelper.php | 2 | ||||
-rw-r--r-- | tests/Settings/Mailer/NewUserMailHelperTest.php | 8 | ||||
-rw-r--r-- | tests/data/emails/new-account-email-custom-text-alternative.txt | 2 | ||||
-rw-r--r-- | tests/data/emails/new-account-email-custom.html | 2 | ||||
-rw-r--r-- | tests/data/emails/new-account-email-custom.txt | 2 | ||||
-rw-r--r-- | tests/data/emails/new-account-email-single-button.html | 2 | ||||
-rw-r--r-- | tests/data/emails/new-account-email-single-button.txt | 2 | ||||
-rw-r--r-- | tests/data/emails/new-account-email.html | 2 | ||||
-rw-r--r-- | tests/data/emails/new-account-email.txt | 2 | ||||
-rw-r--r-- | tests/lib/Mail/EMailTemplateTest.php | 8 |
11 files changed, 17 insertions, 17 deletions
diff --git a/lib/public/Mail/IEMailTemplate.php b/lib/public/Mail/IEMailTemplate.php index ed727444647..3248665a7da 100644 --- a/lib/public/Mail/IEMailTemplate.php +++ b/lib/public/Mail/IEMailTemplate.php @@ -39,7 +39,7 @@ namespace OCP\Mail; * * $emailTemplate->addHeader(); * $emailTemplate->addHeading('Welcome aboard'); - * $emailTemplate->addBodyText('You now have an Nextcloud account, you can add, protect, and share your data.'); + * $emailTemplate->addBodyText('Welcome to your Nextcloud account, you can add, protect, and share your data.'); * * $emailTemplate->addBodyButtonGroup( * 'Set your password', 'https://example.org/resetPassword/q1234567890qwertz', diff --git a/settings/Mailer/NewUserMailHelper.php b/settings/Mailer/NewUserMailHelper.php index db0339c7367..bcd8ae0a538 100644 --- a/settings/Mailer/NewUserMailHelper.php +++ b/settings/Mailer/NewUserMailHelper.php @@ -136,7 +136,7 @@ class NewUserMailHelper { } else { $emailTemplate->addHeading($this->l10n->t('Welcome aboard %s', [$displayName])); } - $emailTemplate->addBodyText($this->l10n->t('You now have an %s account, you can add, protect, and share your data.', [$this->themingDefaults->getName()])); + $emailTemplate->addBodyText($this->l10n->t('Welcome to your %s account, you can add, protect, and share your data.', [$this->themingDefaults->getName()])); $emailTemplate->addBodyText($this->l10n->t('Your username is: %s', [$userId])); if ($generatePasswordResetToken) { $leftButtonText = $this->l10n->t('Set your password'); diff --git a/tests/Settings/Mailer/NewUserMailHelperTest.php b/tests/Settings/Mailer/NewUserMailHelperTest.php index 9fd90561127..f05a963e537 100644 --- a/tests/Settings/Mailer/NewUserMailHelperTest.php +++ b/tests/Settings/Mailer/NewUserMailHelperTest.php @@ -237,7 +237,7 @@ class NewUserMailHelperTest extends TestCase { <table style="border-collapse:collapse;border-spacing:0;padding:0;text-align:left;vertical-align:top;width:100%"> <tr style="padding:0;text-align:left;vertical-align:top"> <th style="Margin:0;color:#0a0a0a;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0;text-align:left"> - <p class="text-left" style="Margin:0;Margin-bottom:10px;color:#777;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0;text-align:left">You now have an TestCloud account, you can add, protect, and share your data.</p> + <p class="text-left" style="Margin:0;Margin-bottom:10px;color:#777;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0;text-align:left">Welcome to your TestCloud account, you can add, protect, and share your data.</p> </th> <th class="expander" style="Margin:0;color:#0a0a0a;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0!important;text-align:left;visibility:hidden;width:0"></th> </tr> @@ -350,7 +350,7 @@ EOF; $expectedTextBody = <<<EOF Welcome aboard -You now have an TestCloud account, you can add, protect, and share your data. +Welcome to your TestCloud account, you can add, protect, and share your data. Your username is: john @@ -470,7 +470,7 @@ EOF; <table style="border-collapse:collapse;border-spacing:0;padding:0;text-align:left;vertical-align:top;width:100%"> <tr style="padding:0;text-align:left;vertical-align:top"> <th style="Margin:0;color:#0a0a0a;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0;text-align:left"> - <p class="text-left" style="Margin:0;Margin-bottom:10px;color:#777;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0;text-align:left">You now have an TestCloud account, you can add, protect, and share your data.</p> + <p class="text-left" style="Margin:0;Margin-bottom:10px;color:#777;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0;text-align:left">Welcome to your TestCloud account, you can add, protect, and share your data.</p> </th> <th class="expander" style="Margin:0;color:#0a0a0a;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0!important;text-align:left;visibility:hidden;width:0"></th> </tr> @@ -583,7 +583,7 @@ EOF; $expectedTextBody = <<<EOF Welcome aboard John Doe -You now have an TestCloud account, you can add, protect, and share your data. +Welcome to your TestCloud account, you can add, protect, and share your data. Your username is: john diff --git a/tests/data/emails/new-account-email-custom-text-alternative.txt b/tests/data/emails/new-account-email-custom-text-alternative.txt index 52da8957ab3..f65744b20d9 100644 --- a/tests/data/emails/new-account-email-custom-text-alternative.txt +++ b/tests/data/emails/new-account-email-custom-text-alternative.txt @@ -1,6 +1,6 @@ Welcome aboard - text -You now have an Nextcloud account, you can add, protect, and share your data. - text +Welcome to your Nextcloud account, you can add, protect, and share your data. - text Your username is: abc diff --git a/tests/data/emails/new-account-email-custom.html b/tests/data/emails/new-account-email-custom.html index f5f3fbda21b..9d35a7f3515 100644 --- a/tests/data/emails/new-account-email-custom.html +++ b/tests/data/emails/new-account-email-custom.html @@ -76,7 +76,7 @@ <table style="border-collapse:collapse;border-spacing:0;padding:0;text-align:left;vertical-align:top;width:100%"> <tr style="padding:0;text-align:left;vertical-align:top"> <th style="Margin:0;color:#0a0a0a;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0;text-align:left"> - <p class="text-left" style="Margin:0;Margin-bottom:10px;color:#777;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0;text-align:left">You now have an Nextcloud account, you can add, protect, and share your data.</p> + <p class="text-left" style="Margin:0;Margin-bottom:10px;color:#777;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0;text-align:left">Welcome to your Nextcloud account, you can add, protect, and share your data.</p> </th> <th class="expander" style="Margin:0;color:#0a0a0a;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0!important;text-align:left;visibility:hidden;width:0"></th> </tr> diff --git a/tests/data/emails/new-account-email-custom.txt b/tests/data/emails/new-account-email-custom.txt index 41ac8de8f49..57c5202a744 100644 --- a/tests/data/emails/new-account-email-custom.txt +++ b/tests/data/emails/new-account-email-custom.txt @@ -1,6 +1,6 @@ Welcome aboard -You now have an Nextcloud account, you can add, protect, and share your data. +Welcome to your Nextcloud account, you can add, protect, and share your data. Your username is: abc diff --git a/tests/data/emails/new-account-email-single-button.html b/tests/data/emails/new-account-email-single-button.html index f3874144109..3746d5d2cbb 100644 --- a/tests/data/emails/new-account-email-single-button.html +++ b/tests/data/emails/new-account-email-single-button.html @@ -76,7 +76,7 @@ <table style="border-collapse:collapse;border-spacing:0;padding:0;text-align:left;vertical-align:top;width:100%"> <tr style="padding:0;text-align:left;vertical-align:top"> <th style="Margin:0;color:#0a0a0a;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0;text-align:left"> - <p class="text-left" style="Margin:0;Margin-bottom:10px;color:#777;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0;text-align:left">You now have an Nextcloud account, you can add, protect, and share your data.</p> + <p class="text-left" style="Margin:0;Margin-bottom:10px;color:#777;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0;text-align:left">Welcome to your Nextcloud account, you can add, protect, and share your data.</p> </th> <th class="expander" style="Margin:0;color:#0a0a0a;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0!important;text-align:left;visibility:hidden;width:0"></th> </tr> diff --git a/tests/data/emails/new-account-email-single-button.txt b/tests/data/emails/new-account-email-single-button.txt index f05f6136d16..0c9210f086a 100644 --- a/tests/data/emails/new-account-email-single-button.txt +++ b/tests/data/emails/new-account-email-single-button.txt @@ -1,6 +1,6 @@ Welcome aboard -You now have an Nextcloud account, you can add, protect, and share your data. +Welcome to your Nextcloud account, you can add, protect, and share your data. Your username is: abc diff --git a/tests/data/emails/new-account-email.html b/tests/data/emails/new-account-email.html index 72daf3ec5c8..d33cb540c38 100644 --- a/tests/data/emails/new-account-email.html +++ b/tests/data/emails/new-account-email.html @@ -76,7 +76,7 @@ <table style="border-collapse:collapse;border-spacing:0;padding:0;text-align:left;vertical-align:top;width:100%"> <tr style="padding:0;text-align:left;vertical-align:top"> <th style="Margin:0;color:#0a0a0a;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0;text-align:left"> - <p class="text-left" style="Margin:0;Margin-bottom:10px;color:#777;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0;text-align:left">You now have an Nextcloud account, you can add, protect, and share your data.</p> + <p class="text-left" style="Margin:0;Margin-bottom:10px;color:#777;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;margin-bottom:10px;padding:0;text-align:left">Welcome to your Nextcloud account, you can add, protect, and share your data.</p> </th> <th class="expander" style="Margin:0;color:#0a0a0a;font-family:Lucida Grande,Geneva,Verdana,sans-serif;font-size:16px;font-weight:400;line-height:1.3;margin:0;padding:0!important;text-align:left;visibility:hidden;width:0"></th> </tr> diff --git a/tests/data/emails/new-account-email.txt b/tests/data/emails/new-account-email.txt index 66d7dbc906a..89524134183 100644 --- a/tests/data/emails/new-account-email.txt +++ b/tests/data/emails/new-account-email.txt @@ -1,6 +1,6 @@ Welcome aboard -You now have an Nextcloud account, you can add, protect, and share your data. +Welcome to your Nextcloud account, you can add, protect, and share your data. Your username is: abc diff --git a/tests/lib/Mail/EMailTemplateTest.php b/tests/lib/Mail/EMailTemplateTest.php index fce214a82aa..339cd95defc 100644 --- a/tests/lib/Mail/EMailTemplateTest.php +++ b/tests/lib/Mail/EMailTemplateTest.php @@ -76,7 +76,7 @@ class EMailTemplateTest extends TestCase { $this->emailTemplate->addHeader(); $this->emailTemplate->addHeading('Welcome aboard'); - $this->emailTemplate->addBodyText('You now have an Nextcloud account, you can add, protect, and share your data.'); + $this->emailTemplate->addBodyText('Welcome to your Nextcloud account, you can add, protect, and share your data.'); $this->emailTemplate->addBodyText('Your username is: abc'); $this->emailTemplate->addBodyButtonGroup( 'Set your password', 'https://example.org/resetPassword/123', @@ -117,7 +117,7 @@ class EMailTemplateTest extends TestCase { $this->emailTemplate->addHeader(); $this->emailTemplate->addHeading('Welcome aboard'); - $this->emailTemplate->addBodyText('You now have an Nextcloud account, you can add, protect, and share your data.'); + $this->emailTemplate->addBodyText('Welcome to your Nextcloud account, you can add, protect, and share your data.'); $this->emailTemplate->addBodyText('Your username is: abc'); $this->emailTemplate->addBodyButtonGroup( 'Set your password', 'https://example.org/resetPassword/123', @@ -156,7 +156,7 @@ class EMailTemplateTest extends TestCase { $this->emailTemplate->addHeader(); $this->emailTemplate->addHeading('Welcome aboard'); - $this->emailTemplate->addBodyText('You now have an Nextcloud account, you can add, protect, and share your data.'); + $this->emailTemplate->addBodyText('Welcome to your Nextcloud account, you can add, protect, and share your data.'); $this->emailTemplate->addBodyText('Your username is: abc'); $this->emailTemplate->addBodyButton( 'Set your password', 'https://example.org/resetPassword/123', @@ -197,7 +197,7 @@ class EMailTemplateTest extends TestCase { $this->emailTemplate->addHeader(); $this->emailTemplate->addHeading('Welcome aboard', 'Welcome aboard - text'); - $this->emailTemplate->addBodyText('You now have an Nextcloud account, you can add, protect, and share your data.', 'You now have an Nextcloud account, you can add, protect, and share your data. - text'); + $this->emailTemplate->addBodyText('Welcome to your Nextcloud account, you can add, protect, and share your data.', 'Welcome to your Nextcloud account, you can add, protect, and share your data. - text'); $this->emailTemplate->addBodyText('Your username is: abc'); $this->emailTemplate->addBodyButtonGroup( 'Set your password', 'https://example.org/resetPassword/123', |