summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoas Schilling <coding@schilljs.com>2019-03-06 11:56:44 +0100
committerJoas Schilling <coding@schilljs.com>2019-03-07 10:04:22 +0100
commitfee02bbcaa332cf8002f1771fb23a7974d00240e (patch)
tree6acc3700cfa4f38d302a93f9dd3815da9238a839
parente828bfca1ed868fe0292b91cd46b9ef47b6311c8 (diff)
downloadnextcloud-server-fee02bbcaa332cf8002f1771fb23a7974d00240e.tar.gz
nextcloud-server-fee02bbcaa332cf8002f1771fb23a7974d00240e.zip
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
-rw-r--r--settings/Activity/GroupProvider.php6
-rw-r--r--settings/Application.php5
-rw-r--r--settings/Hooks.php4
3 files changed, 7 insertions, 8 deletions
diff --git a/settings/Activity/GroupProvider.php b/settings/Activity/GroupProvider.php
index 866cb083662..ac547f07f8f 100644
--- a/settings/Activity/GroupProvider.php
+++ b/settings/Activity/GroupProvider.php
@@ -37,8 +37,8 @@ use OCP\L10N\IFactory as L10nFactory;
class GroupProvider implements IProvider {
- public const ADDED_TO_GROUP = 'group_added';
- public const REMOVED_FROM_GROUP = 'group_removed';
+ const ADDED_TO_GROUP = 'group_added';
+ const REMOVED_FROM_GROUP = 'group_removed';
/** @var L10nFactory */
private $l10n;
@@ -132,7 +132,7 @@ class GroupProvider implements IProvider {
* @param array $parameters
* @throws \InvalidArgumentException
*/
- protected function setSubjects(IEvent $event, string $subject, array $parameters): void {
+ protected function setSubjects(IEvent $event, string $subject, array $parameters) {
$placeholders = $replacements = [];
foreach ($parameters as $placeholder => $parameter) {
$placeholders[] = '{' . $placeholder . '}';
diff --git a/settings/Application.php b/settings/Application.php
index ff776b4227b..e6efdf1d267 100644
--- a/settings/Application.php
+++ b/settings/Application.php
@@ -44,7 +44,6 @@ use OCP\AppFramework\App;
use OCP\Defaults;
use OCP\IContainer;
use OCP\IGroup;
-use OCP\ILogger;
use OCP\IUser;
use OCP\Settings\IManager;
use OCP\Util;
@@ -136,14 +135,14 @@ class Application extends App {
Util::connectHook('\OCP\Config', 'js', $this, 'extendJsConfig');
}
- public function addUserToGroup(IGroup $group, IUser $user): void {
+ public function addUserToGroup(IGroup $group, IUser $user) {
/** @var Hooks $hooks */
$hooks = $this->getContainer()->query(Hooks::class);
$hooks->addUserToGroup($group, $user);
}
- public function removeUserFromGroup(IGroup $group, IUser $user): void {
+ public function removeUserFromGroup(IGroup $group, IUser $user) {
/** @var Hooks $hooks */
$hooks = $this->getContainer()->query(Hooks::class);
$hooks->removeUserFromGroup($group, $user);
diff --git a/settings/Hooks.php b/settings/Hooks.php
index 49189ca082e..3a75ff71411 100644
--- a/settings/Hooks.php
+++ b/settings/Hooks.php
@@ -224,7 +224,7 @@ class Hooks {
* @throws \InvalidArgumentException
* @throws \BadMethodCallException
*/
- public function addUserToGroup(IGroup $group, IUser $user): void {
+ public function addUserToGroup(IGroup $group, IUser $user) {
$subAdminManager = $this->groupManager->getSubAdmin();
$usersToNotify = $subAdminManager->getGroupsSubAdmins($group);
$usersToNotify[] = $user;
@@ -261,7 +261,7 @@ class Hooks {
* @throws \InvalidArgumentException
* @throws \BadMethodCallException
*/
- public function removeUserFromGroup(IGroup $group, IUser $user): void {
+ public function removeUserFromGroup(IGroup $group, IUser $user) {
$subAdminManager = $this->groupManager->getSubAdmin();
$usersToNotify = $subAdminManager->getGroupsSubAdmins($group);
$usersToNotify[] = $user;