summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoeland Jago Douma <rullzer@users.noreply.github.com>2020-01-30 22:07:42 +0100
committerGitHub <noreply@github.com>2020-01-30 22:07:42 +0100
commitd411f9fef9d758ea12f7f45e5e9cf8da2f027b79 (patch)
treeefa6604cff4e32220b17df88e6ba1a9a61e83cde
parent0a95ba10f11770c423e0c9de96ea928c464a9b84 (diff)
parent78cc8e2e7b60bf20982013c4f2edc1c8cd3fa6b5 (diff)
downloadnextcloud-server-d411f9fef9d758ea12f7f45e5e9cf8da2f027b79.tar.gz
nextcloud-server-d411f9fef9d758ea12f7f45e5e9cf8da2f027b79.zip
Merge pull request #19208 from nextcloud/backport/19176/stable17
[stable17] Do not encode contacts menu mailto links
-rw-r--r--lib/private/Contacts/ContactsMenu/ActionFactory.php2
-rw-r--r--tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php2
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/private/Contacts/ContactsMenu/ActionFactory.php b/lib/private/Contacts/ContactsMenu/ActionFactory.php
index 6bc724bd439..2841c5ad206 100644
--- a/lib/private/Contacts/ContactsMenu/ActionFactory.php
+++ b/lib/private/Contacts/ContactsMenu/ActionFactory.php
@@ -50,7 +50,7 @@ class ActionFactory implements IActionFactory {
* @return ILinkAction
*/
public function newEMailAction($icon, $name, $email) {
- return $this->newLinkAction($icon, $name, 'mailto:' . urlencode($email));
+ return $this->newLinkAction($icon, $name, 'mailto:' . $email);
}
}
diff --git a/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php b/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php
index d1273c2b9ad..299946ed21c 100644
--- a/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php
+++ b/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php
@@ -61,7 +61,7 @@ class ActionFactoryTest extends TestCase {
$this->assertInstanceOf(IAction::class, $action);
$this->assertEquals($name, $action->getName());
$this->assertEquals(10, $action->getPriority());
- $this->assertEquals('mailto:user%40example.com', $action->getHref());
+ $this->assertEquals('mailto:user@example.com', $action->getHref());
}
}