summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Calviño Sánchez <danxuliu@gmail.com>2020-06-11 23:16:34 +0200
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>2020-06-24 19:24:58 +0000
commita3f1bb70bda2546119a0002f72e88ee09a7c242d (patch)
treeec90bbd42c68e76d6a751c3c313727ce81363286
parent47222e9ad4ae55176200fbd31109ef3bf333ee7f (diff)
downloadnextcloud-server-a3f1bb70bda2546119a0002f72e88ee09a7c242d.tar.gz
nextcloud-server-a3f1bb70bda2546119a0002f72e88ee09a7c242d.zip
Add acceptance test for sharing a folder without create permission
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
-rw-r--r--tests/acceptance/features/app-files-sharing.feature20
-rw-r--r--tests/acceptance/features/bootstrap/FilesAppSharingContext.php55
2 files changed, 75 insertions, 0 deletions
diff --git a/tests/acceptance/features/app-files-sharing.feature b/tests/acceptance/features/app-files-sharing.feature
index 45604470be1..19a3af51713 100644
--- a/tests/acceptance/features/app-files-sharing.feature
+++ b/tests/acceptance/features/app-files-sharing.feature
@@ -314,3 +314,23 @@ Feature: app-files-sharing
Then I see that the file is shared with "user1"
And I see that "user1" can not edit the share
And I see that "user1" can not be allowed to edit the share
+
+ Scenario: sharee can not reshare a folder with create permission if the sharer disables it
+ Given I act as John
+ And I am logged in as the admin
+ And I act as Jane
+ And I am logged in
+ And I act as John
+ And I create a new folder named "Shared folder"
+ And I see that the file list contains a file named "Shared folder"
+ And I share "Shared folder" with "user0"
+ And I see that the file is shared with "user0"
+ And I set the share with "user0" as not creatable
+ And I see that "user0" can not create in the share
+ When I act as Jane
+ # The Files app is open again to reload the file list
+ And I open the Files app
+ And I share "Shared folder" with "user1"
+ Then I see that the file is shared with "user1"
+ And I see that "user1" can not create in the share
+ And I see that "user1" can not be allowed to create in the share
diff --git a/tests/acceptance/features/bootstrap/FilesAppSharingContext.php b/tests/acceptance/features/bootstrap/FilesAppSharingContext.php
index 81b35ed8676..f95b5e48c8b 100644
--- a/tests/acceptance/features/bootstrap/FilesAppSharingContext.php
+++ b/tests/acceptance/features/bootstrap/FilesAppSharingContext.php
@@ -139,6 +139,20 @@ class FilesAppSharingContext implements Context, ActorAwareInterface {
/**
* @return Locator
*/
+ public static function canCreateCheckbox($sharedWithName) {
+ return self::permissionCheckboxFor($sharedWithName, 'Allow creating');
+ }
+
+ /**
+ * @return Locator
+ */
+ public static function canCreateCheckboxInput($sharedWithName) {
+ return self::permissionCheckboxInputFor($sharedWithName, 'Allow creating');
+ }
+
+ /**
+ * @return Locator
+ */
public static function canReshareCheckbox($sharedWithName) {
return self::permissionCheckboxFor($sharedWithName, 'Allow resharing');
}
@@ -399,6 +413,17 @@ class FilesAppSharingContext implements Context, ActorAwareInterface {
}
/**
+ * @When I set the share with :shareWithName as not creatable
+ */
+ public function iSetTheShareWithAsNotCreatable($shareWithName) {
+ $this->showShareWithMenuIfNeeded($shareWithName);
+
+ $this->iSeeThatCanCreateInTheShare($shareWithName);
+
+ $this->actor->find(self::canCreateCheckbox($shareWithName), 2)->click();
+ }
+
+ /**
* @When I set the share with :shareWithName as not reshareable
*/
public function iSetTheShareWithAsNotReshareable($shareWithName) {
@@ -466,6 +491,36 @@ class FilesAppSharingContext implements Context, ActorAwareInterface {
}
/**
+ * @Then I see that :sharedWithName can not be allowed to create in the share
+ */
+ public function iSeeThatCanNotBeAllowedToCreateInTheShare($sharedWithName) {
+ $this->showShareWithMenuIfNeeded($sharedWithName);
+
+ PHPUnit_Framework_Assert::assertEquals(
+ $this->actor->find(self::canCreateCheckboxInput($sharedWithName), 10)->getWrappedElement()->getAttribute("disabled"), "disabled");
+ }
+
+ /**
+ * @Then I see that :sharedWithName can create in the share
+ */
+ public function iSeeThatCanCreateInTheShare($sharedWithName) {
+ $this->showShareWithMenuIfNeeded($sharedWithName);
+
+ PHPUnit_Framework_Assert::assertTrue(
+ $this->actor->find(self::canCreateCheckboxInput($sharedWithName), 10)->isChecked());
+ }
+
+ /**
+ * @Then I see that :sharedWithName can not create in the share
+ */
+ public function iSeeThatCanNotCreateInTheShare($sharedWithName) {
+ $this->showShareWithMenuIfNeeded($sharedWithName);
+
+ PHPUnit_Framework_Assert::assertFalse(
+ $this->actor->find(self::canCreateCheckboxInput($sharedWithName), 10)->isChecked());
+ }
+
+ /**
* @Then I see that :sharedWithName can reshare the share
*/
public function iSeeThatCanReshareTheShare($sharedWithName) {