diff options
| author | Morris Jobke <hey@morrisjobke.de> | 2015-04-19 00:29:09 +0200 |
|---|---|---|
| committer | Morris Jobke <hey@morrisjobke.de> | 2015-04-19 00:29:09 +0200 |
| commit | 9b8ebdadf7e12fdaaab03d583602341a6a0210aa (patch) | |
| tree | 499cd6fca699d295beaf10d6b1be89e34df01b5b | |
| parent | cdf82909b8225a885fbf92b78208fb1fe258853e (diff) | |
| download | nextcloud-server-9b8ebdadf7e12fdaaab03d583602341a6a0210aa.tar.gz nextcloud-server-9b8ebdadf7e12fdaaab03d583602341a6a0210aa.zip | |
Reduce call of legacy wrapper by call the OCP directly
* ref #15734
* reduces the call depth, because the private methods just call OCP stuff
| -rw-r--r-- | lib/public/db.php | 13 | ||||
| -rw-r--r-- | lib/public/files.php | 4 | ||||
| -rw-r--r-- | lib/public/util.php | 2 |
3 files changed, 10 insertions, 9 deletions
diff --git a/lib/public/db.php b/lib/public/db.php index c188352d77b..6e6c5222ec4 100644 --- a/lib/public/db.php +++ b/lib/public/db.php @@ -85,7 +85,7 @@ class DB { * @since 4.5.0 */ public static function insertid($table=null) { - return(\OC_DB::insertid($table)); + return \OC::$server->getDatabaseConnection()->lastInsertId($table); } /** @@ -93,7 +93,7 @@ class DB { * @since 4.5.0 */ public static function beginTransaction() { - \OC_DB::beginTransaction(); + \OC::$server->getDatabaseConnection()->beginTransaction(); } /** @@ -101,7 +101,7 @@ class DB { * @since 4.5.0 */ public static function commit() { - \OC_DB::commit(); + \OC::$server->getDatabaseConnection()->commit(); } /** @@ -109,7 +109,7 @@ class DB { * @since 8.0.0 */ public static function rollback() { - \OC_DB::rollback(); + \OC::$server->getDatabaseConnection()->rollback(); } /** @@ -119,7 +119,8 @@ class DB { * @since 4.5.0 */ public static function isError($result) { - return(\OC_DB::isError($result)); + // Doctrine returns false on error (and throws an exception) + return $result === false; } /** @@ -129,7 +130,7 @@ class DB { * @since 6.0.0 */ public static function getErrorMessage() { - return(\OC_DB::getErrorMessage()); + return \OC::$server->getDatabaseConnection()->getError(); } } diff --git a/lib/public/files.php b/lib/public/files.php index 57747a4c354..157d4a0a1ee 100644 --- a/lib/public/files.php +++ b/lib/public/files.php @@ -94,7 +94,7 @@ class Files { * @since 5.0.0 */ public static function tmpFile( $postfix='' ) { - return(\OC_Helper::tmpFile( $postfix )); + return \OC::$server->getTempManager()->getTemporaryFile($postfix); } /** @@ -105,7 +105,7 @@ class Files { * @since 5.0.0 */ public static function tmpFolder() { - return(\OC_Helper::tmpFolder()); + return \OC::$server->getTempManager()->getTemporaryFolder(); } /** diff --git a/lib/public/util.php b/lib/public/util.php index bc7f1b1f443..130cacd7264 100644 --- a/lib/public/util.php +++ b/lib/public/util.php @@ -395,7 +395,7 @@ class Util { * @since 4.0.0 */ public static function imagePath( $app, $image ) { - return(\OC_Helper::imagePath( $app, $image )); + return \OC::$server->getURLGenerator()->imagePath($app, $image); } /** |