summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMorris Jobke <hey@morrisjobke.de>2015-04-18 23:37:32 +0200
committerMorris Jobke <hey@morrisjobke.de>2015-04-18 23:37:32 +0200
commit60b8aa2a83fe100f410a6d80b09adaf882619301 (patch)
treee53a67e7a5bd12de3d27cacd3887be832165f2fe
parentcdf82909b8225a885fbf92b78208fb1fe258853e (diff)
downloadnextcloud-server-60b8aa2a83fe100f410a6d80b09adaf882619301.tar.gz
nextcloud-server-60b8aa2a83fe100f410a6d80b09adaf882619301.zip
Removed OC_BackgroundJob - reduce class overhead
* method code is now in the static public namespace (5 sloc)
-rw-r--r--cron.php4
-rw-r--r--lib/private/backgroundjob.php56
-rw-r--r--lib/public/backgroundjob.php7
3 files changed, 7 insertions, 60 deletions
diff --git a/cron.php b/cron.php
index 8c02536744e..6ace29650ee 100644
--- a/cron.php
+++ b/cron.php
@@ -64,7 +64,7 @@ try {
\OC::$server->getTempManager()->cleanOld();
// Exit if background jobs are disabled!
- $appMode = OC_BackgroundJob::getExecutionType();
+ $appMode = \OCP\BackgroundJob::getExecutionType();
if ($appMode == 'none') {
if (OC::$CLI) {
echo 'Background Jobs are disabled!' . PHP_EOL;
@@ -107,7 +107,7 @@ try {
// We call ownCloud from the CLI (aka cron)
if ($appMode != 'cron') {
- OC_BackgroundJob::setExecutionType('cron');
+ \OCP\BackgroundJob::setExecutionType('cron');
}
// open the file and try to lock if. If it is not locked, the background
diff --git a/lib/private/backgroundjob.php b/lib/private/backgroundjob.php
deleted file mode 100644
index 574109feee1..00000000000
--- a/lib/private/backgroundjob.php
+++ /dev/null
@@ -1,56 +0,0 @@
-<?php
-/**
- * @author Bart Visscher <bartv@thisnet.nl>
- * @author Felix Moeller <mail@felixmoeller.de>
- * @author Jakob Sack <mail@jakobsack.de>
- * @author Jörn Friedrich Dreyer <jfd@butonic.de>
- * @author Morris Jobke <hey@morrisjobke.de>
- * @author Scrutinizer Auto-Fixer <auto-fixer@scrutinizer-ci.com>
- *
- * @copyright Copyright (c) 2015, ownCloud, Inc.
- * @license AGPL-3.0
- *
- * This code is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License, version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License, version 3,
- * along with this program. If not, see <http://www.gnu.org/licenses/>
- *
- */
-
-/**
- * This class does the dirty work.
- */
-class OC_BackgroundJob{
- /**
- * get the execution type of background jobs
- * @return string
- *
- * This method returns the type how background jobs are executed. If the user
- * did not select something, the type is ajax.
- */
- public static function getExecutionType() {
- return OC_Appconfig::getValue( 'core', 'backgroundjobs_mode', 'ajax' );
- }
-
- /**
- * sets the background jobs execution type
- * @param string $type execution type
- * @return false|null
- *
- * This method sets the execution type of the background jobs. Possible types
- * are "none", "ajax", "webcron", "cron"
- */
- public static function setExecutionType( $type ) {
- if( !in_array( $type, array('none', 'ajax', 'webcron', 'cron'))) {
- return false;
- }
- return OC_Appconfig::setValue( 'core', 'backgroundjobs_mode', $type );
- }
-}
diff --git a/lib/public/backgroundjob.php b/lib/public/backgroundjob.php
index 40fdd4b6e63..33ccf6545d0 100644
--- a/lib/public/backgroundjob.php
+++ b/lib/public/backgroundjob.php
@@ -60,7 +60,7 @@ class BackgroundJob {
* @since 5.0.0
*/
public static function getExecutionType() {
- return \OC_BackgroundJob::getExecutionType();
+ return \OC::$server->getConfig()->getAppValue('core', 'backgroundjobs_mode', 'ajax');
}
/**
@@ -74,7 +74,10 @@ class BackgroundJob {
* @since 5.0.0
*/
public static function setExecutionType($type) {
- return \OC_BackgroundJob::setExecutionType($type);
+ if( !in_array( $type, array('none', 'ajax', 'webcron', 'cron'))) {
+ return false;
+ }
+ \OC::$server->getConfig()->setAppValue('core', 'backgroundjobs_mode', $type);
}
/**