summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoeland Jago Douma <rullzer@users.noreply.github.com>2020-01-30 22:07:59 +0100
committerGitHub <noreply@github.com>2020-01-30 22:07:59 +0100
commit42adde5132bc2d0c45bdd88ae1446a3e739fa7ce (patch)
tree140c18d13e19eb11263ecd9f31637468b83b4afa
parent560f3a55f0d7e3d948ccbf8d985155f75a350c34 (diff)
parent8aecb95aa4141cec066cf4cdd6e7af4f65ba75d8 (diff)
downloadnextcloud-server-42adde5132bc2d0c45bdd88ae1446a3e739fa7ce.tar.gz
nextcloud-server-42adde5132bc2d0c45bdd88ae1446a3e739fa7ce.zip
Merge pull request #19207 from nextcloud/backport/19176/stable18
[stable18] Do not encode contacts menu mailto links
-rw-r--r--lib/private/Contacts/ContactsMenu/ActionFactory.php2
-rw-r--r--tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php2
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/private/Contacts/ContactsMenu/ActionFactory.php b/lib/private/Contacts/ContactsMenu/ActionFactory.php
index 899ce31ecbd..2c216bf2592 100644
--- a/lib/private/Contacts/ContactsMenu/ActionFactory.php
+++ b/lib/private/Contacts/ContactsMenu/ActionFactory.php
@@ -50,7 +50,7 @@ class ActionFactory implements IActionFactory {
* @return ILinkAction
*/
public function newEMailAction($icon, $name, $email) {
- return $this->newLinkAction($icon, $name, 'mailto:' . urlencode($email));
+ return $this->newLinkAction($icon, $name, 'mailto:' . $email);
}
}
diff --git a/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php b/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php
index 54106bbb642..8e7f64ff9d1 100644
--- a/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php
+++ b/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php
@@ -61,7 +61,7 @@ class ActionFactoryTest extends TestCase {
$this->assertInstanceOf(IAction::class, $action);
$this->assertEquals($name, $action->getName());
$this->assertEquals(10, $action->getPriority());
- $this->assertEquals('mailto:user%40example.com', $action->getHref());
+ $this->assertEquals('mailto:user@example.com', $action->getHref());
}
}