diff options
| author | Morris Jobke <hey@morrisjobke.de> | 2018-11-09 12:13:30 +0100 |
|---|---|---|
| committer | Morris Jobke <hey@morrisjobke.de> | 2018-11-09 12:13:30 +0100 |
| commit | 5273639d0e16e946ec25a51cfdd6696fde3d07cd (patch) | |
| tree | 87a7c45ab576075f6ede17b860c16a81b7b54d7c | |
| parent | 230e93f5756dca187f77c8df3cf69e3d7e3d05ff (diff) | |
| download | nextcloud-server-5273639d0e16e946ec25a51cfdd6696fde3d07cd.tar.gz nextcloud-server-5273639d0e16e946ec25a51cfdd6696fde3d07cd.zip | |
Add deprecation message ofr insertIfNotExist
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| -rw-r--r-- | lib/private/DB/Adapter.php | 1 | ||||
| -rw-r--r-- | lib/private/DB/AdapterSqlite.php | 1 | ||||
| -rw-r--r-- | lib/private/DB/Connection.php | 1 | ||||
| -rw-r--r-- | lib/public/IDBConnection.php | 1 |
4 files changed, 4 insertions, 0 deletions
diff --git a/lib/private/DB/Adapter.php b/lib/private/DB/Adapter.php index 8f062030604..b9a5f272c57 100644 --- a/lib/private/DB/Adapter.php +++ b/lib/private/DB/Adapter.php @@ -92,6 +92,7 @@ class Adapter { * Please note: text fields (clob) must not be used in the compare array * @return int number of inserted rows * @throws \Doctrine\DBAL\DBALException + * @deprecated 15.0.0 - use unique index and "try { $db->insert() } catch (UniqueConstraintViolationException $e) {}" instead, because it is more reliable and does not have the risk for deadlocks - see https://github.com/nextcloud/server/pull/12371 */ public function insertIfNotExist($table, $input, array $compare = null) { if (empty($compare)) { diff --git a/lib/private/DB/AdapterSqlite.php b/lib/private/DB/AdapterSqlite.php index 24650829aa3..0a482259b98 100644 --- a/lib/private/DB/AdapterSqlite.php +++ b/lib/private/DB/AdapterSqlite.php @@ -63,6 +63,7 @@ class AdapterSqlite extends Adapter { * Please note: text fields (clob) must not be used in the compare array * @return int number of inserted rows * @throws \Doctrine\DBAL\DBALException + * @deprecated 15.0.0 - use unique index and "try { $db->insert() } catch (UniqueConstraintViolationException $e) {}" instead, because it is more reliable and does not have the risk for deadlocks - see https://github.com/nextcloud/server/pull/12371 */ public function insertIfNotExist($table, $input, array $compare = null) { if (empty($compare)) { diff --git a/lib/private/DB/Connection.php b/lib/private/DB/Connection.php index 6a64925711a..c63ef0067c1 100644 --- a/lib/private/DB/Connection.php +++ b/lib/private/DB/Connection.php @@ -251,6 +251,7 @@ class Connection extends ReconnectWrapper implements IDBConnection { * Please note: text fields (clob) must not be used in the compare array * @return int number of inserted rows * @throws \Doctrine\DBAL\DBALException + * @deprecated 15.0.0 - use unique index and "try { $db->insert() } catch (UniqueConstraintViolationException $e) {}" instead, because it is more reliable and does not have the risk for deadlocks - see https://github.com/nextcloud/server/pull/12371 */ public function insertIfNotExist($table, $input, array $compare = null) { return $this->adapter->insertIfNotExist($table, $input, $compare); diff --git a/lib/public/IDBConnection.php b/lib/public/IDBConnection.php index 204d7bc99ed..b3abe464845 100644 --- a/lib/public/IDBConnection.php +++ b/lib/public/IDBConnection.php @@ -116,6 +116,7 @@ interface IDBConnection { * @return int number of inserted rows * @throws \Doctrine\DBAL\DBALException * @since 6.0.0 - parameter $compare was added in 8.1.0, return type changed from boolean in 8.1.0 + * @deprecated 15.0.0 - use unique index and "try { $db->insert() } catch (UniqueConstraintViolationException $e) {}" instead, because it is more reliable and does not have the risk for deadlocks - see https://github.com/nextcloud/server/pull/12371 */ public function insertIfNotExist($table, $input, array $compare = null); |