Merge pull request #8922 from nextcloud/deprecated-ocp-files-methods

Deprecated some methods of OCP\Files

2 files changed, 15 insertions, 0 deletions

diff --git a/lib/private/App/CodeChecker/DeprecationCheck.php b/lib/private/App/CodeChecker/DeprecationCheck.php
index 3e843e4f91a..518ab1ec380 100644
--- a/lib/private/App/CodeChecker/DeprecationCheck.php
+++ b/lib/private/App/CodeChecker/DeprecationCheck.php
@@ -46,6 +46,7 @@ class DeprecationCheck extends AbstractCheck {
 			'OCP\User' => '13.0.0',
 			'OCP\BackgroundJob' => '14.0.0',
 			'OCP\App' => '14.0.0',
+			'OCP\Files' => '14.0.0',
 		];
 	}
 
@@ -174,6 +175,13 @@ class DeprecationCheck extends AbstractCheck {
 			'OCP\Util::mb_substr_replace' => '8.2.0',
 			'OCP\Util::sendMail' => '8.1.0',
 			'OCP\Util::writeLog' => '13.0.0',
+
+			'OCP\Files::rmdirr' => '14.0.0',
+			'OCP\Files::getMimeType' => '14.0.0',
+			'OCP\Files::searchByMime' => '14.0.0',
+			'OCP\Files::streamCopy' => '14.0.0',
+			'OCP\Files::buildNotExistingFileName' => '14.0.0',
+			'OCP\Files::getStorage' => '14.0.0',
 		];
 	}
 }
diff --git a/lib/public/Files.php b/lib/public/Files.php
index 7b1b1921ed9..1cfd73fb288 100644
--- a/lib/public/Files.php
+++ b/lib/public/Files.php
@@ -44,12 +44,14 @@ namespace OCP;
  * This class provides access to the internal filesystem abstraction layer. Use
  * this class exlusively if you want to access files
  * @since 5.0.0
+ * @deprecated 14.0.0
  */
 class Files {
 	/**
 	 * Recusive deletion of folders
 	 * @return bool
 	 * @since 5.0.0
+	 * @deprecated 14.0.0
 	 */
 	static public function rmdirr( $dir ) {
 		return \OC_Helper::rmdirr( $dir );
@@ -61,6 +63,7 @@ class Files {
 	 * @return string
 	 * does NOT work for ownClouds filesystem, use OC_FileSystem::getMimeType instead
 	 * @since 5.0.0
+	 * @deprecated 14.0.0
 	 */
 	static public function getMimeType( $path ) {
 		return \OC::$server->getMimeTypeDetector()->detect($path);
@@ -71,6 +74,7 @@ class Files {
 	 * @param string $mimetype
 	 * @return array
 	 * @since 6.0.0
+	 * @deprecated 14.0.0
 	 */
 	static public function searchByMime($mimetype) {
 		return \OC\Files\Filesystem::searchByMime($mimetype);
@@ -82,6 +86,7 @@ class Files {
 	 * @param resource $target
 	 * @return int the number of bytes copied
 	 * @since 5.0.0
+	 * @deprecated 14.0.0
 	 */
 	public static function streamCopy( $source, $target ) {
 		list($count, ) = \OC_Helper::streamCopy( $source, $target );
@@ -94,6 +99,7 @@ class Files {
 	 * @param string $filename
 	 * @return string
 	 * @since 5.0.0
+	 * @deprecated 14.0.0 use getNonExistingName of the OCP\Files\Folder object
 	 */
 	public static function buildNotExistingFileName($path, $filename) {
 		return \OC_Helper::buildNotExistingFileName($path, $filename);
@@ -105,6 +111,7 @@ class Files {
 	 * @param string $app
 	 * @return \OC\Files\View
 	 * @since 5.0.0
+	 * @deprecated 14.0.0 use IAppData instead
 	 */
 	public static function getStorage($app) {
 		return \OC_App::getStorage( $app );