Catch exceptions during sync

2 files changed, 8 insertions, 7 deletions

diff --git a/apps/dav/lib/carddav/syncservice.php b/apps/dav/lib/carddav/syncservice.php
index 494db61d989..b8dfcfdbc5e 100644
--- a/apps/dav/lib/carddav/syncservice.php
+++ b/apps/dav/lib/carddav/syncservice.php
@@ -24,6 +24,7 @@ namespace OCA\DAV\CardDAV;
 use Sabre\DAV\Client;
 use Sabre\DAV\Xml\Response\MultiStatus;
 use Sabre\DAV\Xml\Service;
+use Sabre\HTTP\ClientException;
 
 class SyncService {
 
@@ -112,10 +113,6 @@ class SyncService {
 			'Content-Type' => 'application/xml'
 		]);
 
-//		if ((int)$response->getStatus() >= 400) {
-//			throw new Exception('HTTP error: ' . $response->getStatus());
-//		}
-
 		$result = $this->parseMultiStatus($response['body']);
 
 		return $result;
diff --git a/apps/federation/command/syncfederationaddressbooks.php b/apps/federation/command/syncfederationaddressbooks.php
index d7761d14814..9fb1e51f643 100644
--- a/apps/federation/command/syncfederationaddressbooks.php
+++ b/apps/federation/command/syncfederationaddressbooks.php
@@ -63,9 +63,13 @@ class SyncFederationAddressBooks extends Command {
 			$targetBookProperties = [
 					'{DAV:}displayname' => $url
 			];
-			$newToken = $this->syncService->syncRemoteAddressBook($url, 'system', $sharedSecret, $syncToken, $targetPrincipal, $targetBookId, $targetBookProperties);
-			if ($newToken !== $syncToken) {
-				$this->dbHandler->setServerStatus($url, TrustedServers::STATUS_OK, $newToken);
+			try {
+				$newToken = $this->syncService->syncRemoteAddressBook($url, 'system', $sharedSecret, $syncToken, $targetPrincipal, $targetBookId, $targetBookProperties);
+				if ($newToken !== $syncToken) {
+					$this->dbHandler->setServerStatus($url, TrustedServers::STATUS_OK, $newToken);
+				}
+			} catch (\Exception $ex) {
+				$output->writeln("Error while syncing $url : " . $ex->getMessage());
 			}
 		}
 		$progress->finish();