diff options
author | Mario Danic <mario@lovelyhq.com> | 2017-11-09 00:29:34 +0100 |
---|---|---|
committer | Mario Danic <mario@lovelyhq.com> | 2017-11-09 00:29:34 +0100 |
commit | c2cd5fc5d345a61b6cc251d2974f199f4e8c04f8 (patch) | |
tree | 1da215a5c442419fe8c4886cfb3d8d11a6d46575 | |
parent | 989a8a3668ee2f8214bc0391b8d38f1e9b99bde0 (diff) | |
download | nextcloud-server-c2cd5fc5d345a61b6cc251d2974f199f4e8c04f8.tar.gz nextcloud-server-c2cd5fc5d345a61b6cc251d2974f199f4e8c04f8.zip |
Fix flow
Signed-off-by: Mario Danic <mario@lovelyhq.com>
-rw-r--r-- | core/Controller/ClientFlowLoginController.php | 11 | ||||
-rw-r--r-- | tests/Core/Controller/ClientFlowLoginControllerTest.php | 20 |
2 files changed, 28 insertions, 3 deletions
diff --git a/core/Controller/ClientFlowLoginController.php b/core/Controller/ClientFlowLoginController.php index 81ba8009b24..47bbbce640e 100644 --- a/core/Controller/ClientFlowLoginController.php +++ b/core/Controller/ClientFlowLoginController.php @@ -307,7 +307,16 @@ class ClientFlowLoginController extends Controller { ); $this->session->remove('oauth.state'); } else { - $redirectUri = 'nc://login/server:' . $this->request->getServerHost() . '&user:' . urlencode($loginName) . '&password:' . urlencode($token); + $serverPostfix = ''; + + if (strpos($this->request->getRequestUri(), '/index.php') !== false) { + $serverPostfix = substr($this->request->getRequestUri(), 0, strpos($this->request->getRequestUri(), '/index.php')); + } else if (strpos($this->request->getRequestUri(), '/login/flow') !== false) { + $serverPostfix = substr($this->request->getRequestUri(), 0, strpos($this->request->getRequestUri(), '/login/flow')); + } + + $serverPath = $this->request->getServerProtocol() . "://" . $this->request->getServerHost() . $serverPostfix; + $redirectUri = 'nc://login/server:' . $serverPath . '&user:' . urlencode($loginName) . '&password:' . urlencode($token); } return new Http\RedirectResponse($redirectUri); diff --git a/tests/Core/Controller/ClientFlowLoginControllerTest.php b/tests/Core/Controller/ClientFlowLoginControllerTest.php index 99388e2c441..d2dec685737 100644 --- a/tests/Core/Controller/ClientFlowLoginControllerTest.php +++ b/tests/Core/Controller/ClientFlowLoginControllerTest.php @@ -160,6 +160,10 @@ class ClientFlowLoginControllerTest extends TestCase { ->willReturn('ExampleCloud'); $this->request ->expects($this->once()) + ->method('getServerProtocol') + ->willReturn('http'); + $this->request + ->expects($this->once()) ->method('getServerHost') ->willReturn('example.com'); @@ -216,6 +220,10 @@ class ClientFlowLoginControllerTest extends TestCase { ->willReturn('ExampleCloud'); $this->request ->expects($this->once()) + ->method('getServerProtocol') + ->willReturn('http'); + $this->request + ->expects($this->once()) ->method('getServerHost') ->willReturn('example.com'); @@ -425,10 +433,14 @@ class ClientFlowLoginControllerTest extends TestCase { ); $this->request ->expects($this->once()) + ->method('getServerProtocol') + ->willReturn('http'); + $this->request + ->expects($this->once()) ->method('getServerHost') ->willReturn('example.com'); - $expected = new Http\RedirectResponse('nc://login/server:example.com&user:MyLoginName&password:MyGeneratedToken'); + $expected = new Http\RedirectResponse('nc://login/server:http://example.com&user:MyLoginName&password:MyGeneratedToken'); $this->assertEquals($expected, $this->clientFlowLoginController->generateAppPassword('MyStateToken')); } @@ -573,10 +585,14 @@ class ClientFlowLoginControllerTest extends TestCase { ); $this->request ->expects($this->once()) + ->method('getServerProtocol') + ->willReturn('http'); + $this->request + ->expects($this->once()) ->method('getServerHost') ->willReturn('example.com'); - $expected = new Http\RedirectResponse('nc://login/server:example.com&user:MyLoginName&password:MyGeneratedToken'); + $expected = new Http\RedirectResponse('nc://login/server:http://example.com&user:MyLoginName&password:MyGeneratedToken'); $this->assertEquals($expected, $this->clientFlowLoginController->generateAppPassword('MyStateToken')); } } |