Merge pull request #10023 from owncloud/tmp-file-created-status

Log unsuccessful temp file creation and return false

1 files changed, 14 insertions, 2 deletions

diff --git a/lib/private/helper.php b/lib/private/helper.php
index 17d3840a3ea..7c1edd1b058 100644
--- a/lib/private/helper.php
+++ b/lib/private/helper.php
@@ -579,8 +579,20 @@ class OC_Helper {
 	public static function tmpFile($postfix = '') {
 		$file = get_temp_dir() . '/' . md5(time() . rand()) . $postfix;
 		$fh = fopen($file, 'w');
-		fclose($fh);
-		self::$tmpFiles[] = $file;
+		if ($fh!==false){
+			fclose($fh);
+			self::$tmpFiles[] = $file;
+		} else {
+			OC_Log::write(
+				'OC_Helper',
+				sprintf(
+					'Can not create a temporary file in directory %s. Check it exists and has correct permissions',
+					get_temp_dir()
+				),
+				OC_Log::WARN
+			);
+			$file = false;
+		}
 		return $file;
 	}