summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobin Appelman <robin@icewind.nl>2018-12-10 17:20:45 +0100
committerRobin Appelman <robin@icewind.nl>2018-12-12 14:17:19 +0100
commit6c9f2644cf8bac151b9af743802eb72a51278e8b (patch)
tree161b589821f998cc1e9bc7e7834730fadb5f5edb
parent71df6233cfc4c6a02f90a887d57471430fe38dd7 (diff)
downloadnextcloud-server-6c9f2644cf8bac151b9af743802eb72a51278e8b.tar.gz
nextcloud-server-6c9f2644cf8bac151b9af743802eb72a51278e8b.zip
Add objectExists to objectstore interface
Signed-off-by: Robin Appelman <robin@icewind.nl>
-rw-r--r--lib/private/Files/ObjectStore/Azure.php13
-rw-r--r--lib/private/Files/ObjectStore/S3ObjectTrait.php4
-rw-r--r--lib/private/Files/ObjectStore/StorageObjectStore.php3
-rw-r--r--lib/private/Files/ObjectStore/Swift.php3
-rw-r--r--lib/public/Files/ObjectStore/IObjectStore.php9
-rw-r--r--tests/lib/Files/ObjectStore/ObjectStoreTest.php15
6 files changed, 47 insertions, 0 deletions
diff --git a/lib/private/Files/ObjectStore/Azure.php b/lib/private/Files/ObjectStore/Azure.php
index 899c826ec19..e162c510b98 100644
--- a/lib/private/Files/ObjectStore/Azure.php
+++ b/lib/private/Files/ObjectStore/Azure.php
@@ -115,4 +115,17 @@ class Azure implements IObjectStore {
public function deleteObject($urn) {
$this->getBlobClient()->deleteBlob($this->containerName, $urn);
}
+
+ public function objectExists($urn) {
+ try {
+ $this->getBlobClient()->getBlobMetadata($this->containerName, $urn);
+ return true;
+ } catch (ServiceException $e) {
+ if ($e->getCode() === 404) {
+ return false;
+ } else {
+ throw $e;
+ }
+ }
+ }
}
diff --git a/lib/private/Files/ObjectStore/S3ObjectTrait.php b/lib/private/Files/ObjectStore/S3ObjectTrait.php
index 280a8efa81c..a1110d87c8f 100644
--- a/lib/private/Files/ObjectStore/S3ObjectTrait.php
+++ b/lib/private/Files/ObjectStore/S3ObjectTrait.php
@@ -90,4 +90,8 @@ trait S3ObjectTrait {
'Key' => $urn
]);
}
+
+ public function objectExists($urn) {
+ return $this->getConnection()->doesObjectExist($this->bucket, $urn);
+ }
}
diff --git a/lib/private/Files/ObjectStore/StorageObjectStore.php b/lib/private/Files/ObjectStore/StorageObjectStore.php
index 0d35ba2ed7a..f9fc1b5a4aa 100644
--- a/lib/private/Files/ObjectStore/StorageObjectStore.php
+++ b/lib/private/Files/ObjectStore/StorageObjectStore.php
@@ -89,4 +89,7 @@ class StorageObjectStore implements IObjectStore {
$this->storage->unlink($urn);
}
+ public function objectExists($urn) {
+ return $this->storage->file_exists($urn);
+ }
}
diff --git a/lib/private/Files/ObjectStore/Swift.php b/lib/private/Files/ObjectStore/Swift.php
index e379e54d018..3d6bf9d69da 100644
--- a/lib/private/Files/ObjectStore/Swift.php
+++ b/lib/private/Files/ObjectStore/Swift.php
@@ -128,4 +128,7 @@ class Swift implements IObjectStore {
$this->getContainer()->delete();
}
+ public function objectExists($urn) {
+ return $this->getContainer()->objectExists($urn);
+ }
}
diff --git a/lib/public/Files/ObjectStore/IObjectStore.php b/lib/public/Files/ObjectStore/IObjectStore.php
index 628fd5852da..83c4b1065d6 100644
--- a/lib/public/Files/ObjectStore/IObjectStore.php
+++ b/lib/public/Files/ObjectStore/IObjectStore.php
@@ -63,4 +63,13 @@ interface IObjectStore {
* @since 7.0.0
*/
public function deleteObject($urn);
+
+ /**
+ * Check if an object exists in the object store
+ *
+ * @param string $urn
+ * @return bool
+ * @since 16.0.0
+ */
+ public function objectExists($urn);
}
diff --git a/tests/lib/Files/ObjectStore/ObjectStoreTest.php b/tests/lib/Files/ObjectStore/ObjectStoreTest.php
index 2116306053e..1383c0149a2 100644
--- a/tests/lib/Files/ObjectStore/ObjectStoreTest.php
+++ b/tests/lib/Files/ObjectStore/ObjectStoreTest.php
@@ -94,4 +94,19 @@ abstract class ObjectStoreTest extends TestCase {
$this->assertEquals(1, 1);
}
}
+
+ public function testExists() {
+ $stream = $this->stringToStream('foobar');
+
+ $instance = $this->getInstance();
+ $this->assertFalse($instance->objectExists('2'));
+
+ $instance->writeObject('2', $stream);
+
+ $this->assertTrue($instance->objectExists('2'));
+
+ $instance->deleteObject('2');
+
+ $this->assertFalse($instance->objectExists('2'));
+ }
}