diff options
author | Morris Jobke <hey@morrisjobke.de> | 2020-11-19 23:16:42 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-11-19 23:16:42 +0100 |
commit | 568762a5a5728bec0aff505a5f6dd7910482fbe1 (patch) | |
tree | 57a7a83f1bf1264a4aa9a25fdcb386454b3f3055 | |
parent | 1b613c84e982ceaf273831e52a2ff2438068667b (diff) | |
parent | 9b7bdfef79c84c8899fad4837a71825dcf9c84e8 (diff) | |
download | nextcloud-server-568762a5a5728bec0aff505a5f6dd7910482fbe1.tar.gz nextcloud-server-568762a5a5728bec0aff505a5f6dd7910482fbe1.zip |
Merge pull request #24211 from nextcloud/bugfix/noid/theming-image
Fix setting images through occ for theming
-rw-r--r-- | apps/theming/lib/Command/UpdateConfig.php | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/apps/theming/lib/Command/UpdateConfig.php b/apps/theming/lib/Command/UpdateConfig.php index 7d616879dc6..849744077ef 100644 --- a/apps/theming/lib/Command/UpdateConfig.php +++ b/apps/theming/lib/Command/UpdateConfig.php @@ -94,7 +94,7 @@ class UpdateConfig extends Command { return 0; } - if (!in_array($key, self::SUPPORTED_KEYS, true)) { + if (!in_array($key, self::SUPPORTED_KEYS, true) && !in_array($key, self::SUPPORTED_IMAGE_KEYS, true)) { $output->writeln('<error>Invalid config key provided</error>'); return 1; } @@ -116,11 +116,12 @@ class UpdateConfig extends Command { } if (in_array($key, self::SUPPORTED_IMAGE_KEYS, true)) { - if (file_exists(__DIR__ . $value)) { - $value = __DIR__ . $value; + if (strpos($value, '/') !== 0) { + $output->writeln('<error>The image file needs to be provided as an absolute path: ' . $value . '.</error>'); + return 1; } if (!file_exists($value)) { - $output->writeln('<error>File could not be found: ' . $value . '</error>'); + $output->writeln('<error>File could not be found: ' . $value . '.</error>'); return 1; } $value = $this->imageManager->updateImage($key, $value); |