diff options
| author | Simon L <szaimen@e.mail.de> | 2022-06-27 19:01:52 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-27 19:01:52 +0200 |
| commit | 46642cae4fa5ca06a084949c09a94d6aec251676 (patch) | |
| tree | 239817a1a649efe4eeaf7f47d2f4ca2c714ac471 | |
| parent | 3aff3ef595142ab901bd3672eb451b898d2b3894 (diff) | |
| parent | 6d0d38ae5818e2687a5943bea6b9932a94b1d227 (diff) | |
| download | nextcloud-server-46642cae4fa5ca06a084949c09a94d6aec251676.tar.gz nextcloud-server-46642cae4fa5ca06a084949c09a94d6aec251676.zip | |
Merge pull request #33030 from nextcloud/backport/32968/stable23
[stable23] Do not display the buffer_size info if the size is already set to a c…
| -rw-r--r-- | apps/settings/lib/Controller/CheckSetupController.php | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php index b9f176f97c5..f52c10cf580 100644 --- a/apps/settings/lib/Controller/CheckSetupController.php +++ b/apps/settings/lib/Controller/CheckSetupController.php @@ -525,7 +525,11 @@ Raw output if ( empty($status['interned_strings_usage']['free_memory']) || - ($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) + ( + ($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) && + // Do not recommend to raise the interned strings buffer size above a quarter of the total OPcache size + ($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') < $this->iniGetWrapper->getNumeric('opcache.memory_consumption') / 4) + ) ) { $recommendations[] = $this->l10n->t('The OPcache interned strings buffer is nearly full. To assure that repeating strings can be effectively cached, it is recommended to apply <code>opcache.interned_strings_buffer</code> to your PHP configuration with a value higher than <code>%s</code>.', [($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') ?: 'currently')]); } |