summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobin Appelman <robin@icewind.nl>2021-02-23 17:34:05 +0100
committerbackportbot-nextcloud[bot] <backportbot-nextcloud[bot]@users.noreply.github.com>2022-12-20 15:30:39 +0000
commita2e7f31c77fad0df46ec3eb4285f1441c6258cd9 (patch)
tree0a161304868e89c94736e2251c09493d5fe19150
parent783dae94cf9d0b7bf2165a59e48ecb57345aeebf (diff)
downloadnextcloud-server-a2e7f31c77fad0df46ec3eb4285f1441c6258cd9.tar.gz
nextcloud-server-a2e7f31c77fad0df46ec3eb4285f1441c6258cd9.zip
remove file exists check from `cacheAndReturnMimeType`
the method is only called if the file exists already a check against storing the fallback mimetype is added as a safety instead Signed-off-by: Robin Appelman <robin@icewind.nl>
-rw-r--r--apps/workflowengine/lib/Check/FileMimeType.php4
1 files changed, 2 insertions, 2 deletions
diff --git a/apps/workflowengine/lib/Check/FileMimeType.php b/apps/workflowengine/lib/Check/FileMimeType.php
index 8213010af05..991d7ebc739 100644
--- a/apps/workflowengine/lib/Check/FileMimeType.php
+++ b/apps/workflowengine/lib/Check/FileMimeType.php
@@ -77,7 +77,7 @@ class FileMimeType extends AbstractStringCheck implements IFileCheck {
}
/**
- * The mimetype is only cached if the file exists. Otherwise files access
+ * The mimetype is only cached if the file has a valid mimetype. Otherwise files access
* control will cache "application/octet-stream" for all the target node on:
* rename, move, copy and all other methods which create a new item
*
@@ -92,7 +92,7 @@ class FileMimeType extends AbstractStringCheck implements IFileCheck {
* @return string
*/
protected function cacheAndReturnMimeType(string $storageId, ?string $path, string $mimeType): string {
- if ($path !== null && $this->storage->file_exists($path)) {
+ if ($path !== null && $mimeType !== 'application/octet-stream') {
$this->mimeType[$storageId][$path] = $mimeType;
}