diff options
author | Robin Appelman <robin@icewind.nl> | 2021-02-23 17:34:05 +0100 |
---|---|---|
committer | blizzz (Rebase PR Action) <blizzz@users.noreply.github.com> | 2023-02-07 17:26:32 +0000 |
commit | 8b393454b09cf0a209130c09b6ea04ac1d835e76 (patch) | |
tree | e4bcd80ff048329764709967287ef84c6ecff145 | |
parent | e48d50315dc4efcb83e62d1c1ecd746987f4a43f (diff) | |
download | nextcloud-server-8b393454b09cf0a209130c09b6ea04ac1d835e76.tar.gz nextcloud-server-8b393454b09cf0a209130c09b6ea04ac1d835e76.zip |
remove file exists check from `cacheAndReturnMimeType`
the method is only called if the file exists already
a check against storing the fallback mimetype is added as a safety instead
Signed-off-by: Robin Appelman <robin@icewind.nl>
-rw-r--r-- | apps/workflowengine/lib/Check/FileMimeType.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/apps/workflowengine/lib/Check/FileMimeType.php b/apps/workflowengine/lib/Check/FileMimeType.php index 8213010af05..991d7ebc739 100644 --- a/apps/workflowengine/lib/Check/FileMimeType.php +++ b/apps/workflowengine/lib/Check/FileMimeType.php @@ -77,7 +77,7 @@ class FileMimeType extends AbstractStringCheck implements IFileCheck { } /** - * The mimetype is only cached if the file exists. Otherwise files access + * The mimetype is only cached if the file has a valid mimetype. Otherwise files access * control will cache "application/octet-stream" for all the target node on: * rename, move, copy and all other methods which create a new item * @@ -92,7 +92,7 @@ class FileMimeType extends AbstractStringCheck implements IFileCheck { * @return string */ protected function cacheAndReturnMimeType(string $storageId, ?string $path, string $mimeType): string { - if ($path !== null && $this->storage->file_exists($path)) { + if ($path !== null && $mimeType !== 'application/octet-stream') { $this->mimeType[$storageId][$path] = $mimeType; } |