diff options
| author | Robin Appelman <robin@icewind.nl> | 2022-05-13 15:06:47 +0200 |
|---|---|---|
| committer | Robin Appelman <robin@icewind.nl> | 2022-05-13 15:15:26 +0200 |
| commit | eda997f2bd6e969753ca90c400b790427b2bf684 (patch) | |
| tree | ef0818523ff1fd659b14e791c1ec46d61c546351 | |
| parent | 52bb29bde117f13d8df106bdc6862efe12314448 (diff) | |
| download | nextcloud-server-eda997f2bd6e969753ca90c400b790427b2bf684.tar.gz nextcloud-server-eda997f2bd6e969753ca90c400b790427b2bf684.zip | |
only log diagnostic events if a treshhold is set
this prevents log spam and it's rare that you actually want to very short events logged anyway
Signed-off-by: Robin Appelman <robin@icewind.nl>
| -rw-r--r-- | config/config.sample.php | 4 | ||||
| -rw-r--r-- | lib/private/Diagnostics/EventLogger.php | 2 |
2 files changed, 4 insertions, 2 deletions
diff --git a/config/config.sample.php b/config/config.sample.php index 5c34563f63d..bf6643458fa 100644 --- a/config/config.sample.php +++ b/config/config.sample.php @@ -1791,7 +1791,7 @@ $CONFIG = [ /** * Enforce the user theme. This will disable the user theming settings - * This must be a valid ITheme ID. + * This must be a valid ITheme ID. * E.g. light, dark, highcontrast, dark-highcontrast... */ 'enforce_theme' => '', @@ -2146,6 +2146,8 @@ $CONFIG = [ /** * Limit diagnostics event logging to events longer than the configured threshold in ms + * + * when set to 0 no diagnostics events will be logged */ 'diagnostics.logging.threshold' => 0, diff --git a/lib/private/Diagnostics/EventLogger.php b/lib/private/Diagnostics/EventLogger.php index c7b89002ea9..7b9bd9630ab 100644 --- a/lib/private/Diagnostics/EventLogger.php +++ b/lib/private/Diagnostics/EventLogger.php @@ -126,7 +126,7 @@ class EventLogger implements IEventLogger { $timeInMs = round($duration * 1000, 4); $loggingMinimum = (int)$this->config->getValue('diagnostics.logging.threshold', 0); - if ($loggingMinimum > 0 && $timeInMs < $loggingMinimum) { + if ($loggingMinimum === 0 || $timeInMs < $loggingMinimum) { return; } |